Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster roles & rolebindings #84

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

radu-catalina
Copy link
Contributor

Add missing cluster roles and rolebindings to fix:

E1020 11:46:07.519618       1 reflector.go:148] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:231: Failed to watch *v1.Cluster: failed to list *v1.Cluster: clusters.registry.ethos.adobe.com is forbidden: User "system:serviceaccount:cluster-registry:cluster-registry-client" cannot list resource "clusters" in API group "registry.ethos.adobe.com" at the cluster scope

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@radu-catalina radu-catalina requested a review from a team as a code owner October 24, 2023 08:46
@radu-catalina radu-catalina changed the title Add clroles Add cluster roles & rolebindings Oct 24, 2023
Copy link
Contributor

@palasanu palasanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@adriananeci adriananeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aalexandru aalexandru merged commit 91510eb into adobe:main Oct 25, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants