Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for image pull secrets for the helm chart #81

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Add support for image pull secrets for the helm chart #81

merged 2 commits into from
Oct 12, 2023

Conversation

adriananeci
Copy link
Contributor

@adriananeci adriananeci commented Oct 12, 2023 •
edited
Loading

Add support for image pull secrets for the helm chart

Expose image pull secrets so that we can pull images from private registries.

It also format a bit the yaml files using the output from yamlfix

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@adriananeci adriananeci requested a review from a team as a code owner October 12, 2023 13:16
palasanu
palasanu approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@palasanu palasanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

victorvarza
victorvarza approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@victorvarza victorvarza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rdtiu
rdtiu approved these changes Oct 12, 2023
View reviewed changes
Copy link

@rdtiu rdtiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

JonnieDoe
JonnieDoe reviewed Oct 12, 2023
View reviewed changes
Copy link

@JonnieDoe JonnieDoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adriananeci adriananeci merged commit 74757d7 into adobe:main Oct 12, 2023
1 of 2 checks passed
@adriananeci adriananeci deleted the chart_fixes branch October 12, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonnieDoe JonnieDoe JonnieDoe left review comments

@victorvarza victorvarza victorvarza approved these changes

@palasanu palasanu palasanu approved these changes

@rdtiu rdtiu rdtiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adriananeci @rdtiu @JonnieDoe @palasanu @victorvarza