-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recommended helm labels #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalexandru
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
radu-catalina
force-pushed
the
add-missing-helm-labels
branch
from
August 29, 2023 11:25
603dc34
to
e7c6ee1
Compare
Merged
aalexandru
pushed a commit
to aalexandru/cluster-registry
that referenced
this pull request
Sep 4, 2023
* Add recommended helm labels * Increase chart version
aalexandru
pushed a commit
to aalexandru/cluster-registry
that referenced
this pull request
Sep 18, 2023
* Add recommended helm labels * Increase chart version
aalexandru
pushed a commit
to aalexandru/cluster-registry
that referenced
this pull request
Sep 18, 2023
* Add recommended helm labels * Increase chart version
aalexandru
added a commit
that referenced
this pull request
Oct 3, 2023
* Add service metadata endpoints * New release 1.5.0-unstable (#70) Co-authored-by: aalexandru <[email protected]> * Add chargebackBusinessUnit field; Remove k8sInfraRelease field (#74) * Add chargebackBusinessUnit field; Remove k8sInfraRelease field * Fix go deps * go mod tidy * Updated controller-gen version * Fix go.sum imports * Bump go version to 1.21 * Refactor deprecated clientConfig * Refactor clientConfig webhook configuration * Fix G304 (CWE-22) * Add missing license * Update makefile K8S_VERSION to 1.25.0 * Update controller-gen crd options --------- Co-authored-by: aalexandru <[email protected]> * Add recommended helm labels (#71) * Add recommended helm labels * Increase chart version * New release 1.4.2 (#75) Co-authored-by: aalexandru <[email protected]> * Fix leader election (#76) Co-authored-by: aalexandru <[email protected]> * Update kind version * Add new crd & controller reconciliation logic * Updated serviceMetadata patching logic * make swagger * Add chargebackBusinessUnit field; Remove k8sInfraRelease field (#74) * Add chargebackBusinessUnit field; Remove k8sInfraRelease field * Fix go deps * go mod tidy * Updated controller-gen version * Fix go.sum imports * Bump go version to 1.21 * Refactor deprecated clientConfig * Refactor clientConfig webhook configuration * Fix G304 (CWE-22) * Add missing license * Update makefile K8S_VERSION to 1.25.0 * Update controller-gen crd options --------- Co-authored-by: aalexandru <[email protected]> * Update kind version * Add new crd & controller reconciliation logic * Updated serviceMetadata patching logic * make swagger * Add client config defaults * Updated service metadata patching logic * Ignore service object delete events * Fix linting errors * Add missing license --------- Co-authored-by: aalexandru <[email protected]> Co-authored-by: caradu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the recommended helm labels to all resources
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: