Fixed a CSS error in Adobe Target move and resize actions #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninaceban
requested changes
Oct 31, 2024
src/components/Personalization/dom-actions/initDomActionsModules.js
Outdated
Show resolved
Hide resolved
|
Thanks @ninaceban. I've updated the code with your suggestions. |
jonsnyder
approved these changes
Oct 31, 2024
jonsnyder
changed the title
ramboz
pushed a commit
to ramboz/alloy
that referenced
this pull request
Nov 7, 2024
* [PDCL-12744] Implement move action * Coerce css value to string before calling endsWith --------- Co-authored-by: jonsnyder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personalization move action is not taking into account values that come from the edge server and are not properly formatted.
A valid css value would be
left: 400px;but the edge server sends only the numerical value resulting into an invalid css value and the move action failes.Description
Appends "px" string if required to the coordinates for the move action.
Motivation and Context
Broken personalization for the move action.
Types of changes
Checklist: