PDCL-11250 (#1076)

adobe · Oct 30, 2023 · 3cc9f30 · 3cc9f30
1 parent 1d68658
commit 3cc9f30
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 4 deletions.
diff --git a/sandbox/src/components/InAppMessagesDemo/InAppMessages.js b/sandbox/src/components/InAppMessagesDemo/InAppMessages.js
@@ -3,7 +3,8 @@ import React, { useEffect, useState } from "react";
 import ContentSecurityPolicy from "../ContentSecurityPolicy";
 import "./InAppMessagesStyle.css";
 
-const configKey = localStorage.getItem("iam-configKey") || "stage";
+const configKey =
+  localStorage.getItem("iam-configKey") || "aemonacpprodcampaign";
 
 const config = {
   cjmProdNld2: {

diff --git a/src/components/DecisioningEngine/createEvaluableRulesetPayload.js b/src/components/DecisioningEngine/createEvaluableRulesetPayload.js
@@ -75,9 +75,8 @@ export default (payload, eventRegistry, decisionHistory) => {
     )
       .map(consequenceAdapter)
       .map(item => {
-        const {
-          firstTimestamp: qualifiedDate
-        } = decisionHistory.recordQualified(activityId);
+        const { firstTimestamp: qualifiedDate } =
+          decisionHistory.recordQualified(activityId) || {};
 
         return {
           ...item,

diff --git a/src/components/DecisioningEngine/createEventRegistry.js b/src/components/DecisioningEngine/createEventRegistry.js
@@ -66,6 +66,10 @@ export default ({ storage }) => {
   setStorage(storage);
 
   const addEvent = (event, eventType, eventId, action) => {
+    if (!eventType || !eventId) {
+      return undefined;
+    }
+
     if (!events[eventType]) {
       events[eventType] = {};
     }

diff --git a/test/unit/specs/components/DecisioningEngine/createEventRegistry.spec.js b/test/unit/specs/components/DecisioningEngine/createEventRegistry.spec.js
@@ -131,6 +131,46 @@ describe("DecisioningEngine:createEventRegistry", () => {
     expect(eventRegistry.toJSON()).toEqual({});
   });
 
+  it("does not register events without type and id", () => {
+    const eventRegistry = createEventRegistry({ storage });
+
+    expect(eventRegistry.addEvent({}, "trigger")).toBeUndefined();
+    expect(eventRegistry.addEvent({}, "trigger", undefined)).toBeUndefined();
+    expect(eventRegistry.addEvent({})).toBeUndefined();
+
+    expect(eventRegistry.toJSON()).toEqual({});
+
+    expect(
+      eventRegistry.addEvent({ something: "special" }, "display", "abc#123")
+    ).toEqual({
+      event: {
+        "iam.id": "abc#123",
+        "iam.eventType": "display",
+        "iam.action": undefined,
+        something: "special"
+      },
+      firstTimestamp: jasmine.any(Number),
+      timestamp: jasmine.any(Number),
+      count: 1
+    });
+
+    expect(eventRegistry.toJSON()).toEqual({
+      display: {
+        "abc#123": {
+          event: {
+            "iam.id": "abc#123",
+            "iam.eventType": "display",
+            "iam.action": undefined,
+            something: "special"
+          },
+          firstTimestamp: jasmine.any(Number),
+          timestamp: jasmine.any(Number),
+          count: 1
+        }
+      }
+    });
+  });
+
   it("increments count and sets timestamp", done => {
     const eventRegistry = createEventRegistry({ storage });