Merge pull request #46 from adobe/ie_working_sandbox

Get the sandbox working in IE
adobe · Jun 3, 2019 · 01e5e19 · 01e5e19
2 parents 65cbf5f + 62df5e7
commit 01e5e19
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/sandbox/public/index.html b/sandbox/public/index.html
@@ -5,6 +5,7 @@
     <link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico" />
     <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no" />
     <meta name="theme-color" content="#000000" />
+    <script src="https://cdn.jsdelivr.net/npm/promise-polyfill@8/dist/polyfill.min.js"></script>
     <meta http-equiv="Content-Security-Policy"
           content="default-src 'self';
             script-src 'self' 'unsafe-inline';
@@ -39,7 +40,7 @@
           "xdm:URL": [location.href],
           "xdm:name": [location.pathname.substring(1) || "home"]
         }
-      }).then(() => {
+      }).then(function() {
         console.log("View start event has triggered.");
       });
 

diff --git a/src/components/Personalization/index.js b/src/components/Personalization/index.js
@@ -76,7 +76,10 @@ const showElement = selector => {
   const key = buildKey(KEY_PREFIX, selector);
   const elements = document.querySelectorAll(`.${key}`);
 
-  elements.forEach(e => removeFrom(document.head, e));
+  // elements is a nodeList, and in IE nodeList does not support forEach
+  for (let i = 0; i < elements.length; i += 1) {
+    removeFrom(document.head, elements[i]);
+  }
 };
 
 const render = (cache, event, logger) => {
@@ -150,7 +153,6 @@ const createPersonalization = ({ logger }) => {
           response.getPayloadByType("personalization:run") || [];
 
         // Caution!!! Here comes Target black magic
-
         personalization.forEach(option => {
           const { selector, eventToken } = option;
           const key = buildKey(KEY_DETECT_PREFIX, selector);

diff --git a/src/core/network/xhrRequest.js b/src/core/network/xhrRequest.js
@@ -31,7 +31,9 @@ export default XMLHttpRequest => {
           }
         }
       };
-      request.responseType = "text";
+      request.onloadstart = () => {
+        request.responseType = "text";
+      };
       request.open("POST", url, true);
       request.setRequestHeader("Content-Type", "application/json");
       request.withCredentials = false;