feat: access_token is stored in global conf not local .aio

[jsedding]

reviewer's note: this fix is essentially, if the context is local (thus overriding any global), persist to local.

Description

This change checks where an IMS context is defined, and stores the tokens in the same location (i.e. local or global).

Furthermore, on logout, only the tokens are removed, rather than the entire IMS context being rewritten, as was the case previously. The context data is the merged view of global and local configs for a context, so rewriting it risks accidentally copying data between the local IMS context definition and the global one.

Related Issue

fixes #67

Motivation and Context

We want to leverage IMS contexts in the aio-cli-plugin-aem-rde to make usage more convenient for users.

How Has This Been Tested?

This was manually tested by verifying the date was written to and deleted from the correct configuration files. The small change in StateActionContext is only a guess/best effort. I don't know in which scenario this implementation is used, so couldn't test.

Also, existing test cases were adjusted.

Screenshots (if appropriate):

Types of changes

• Enhancement / bug fix
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[shazron]

Make sure the test runner passes (coverage should be 100%)

[shazron]

Everything else looks good except test coverage needs to be completed:

------------------------|---------|----------|---------|---------|-------------------
File                    | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------------------|---------|----------|---------|---------|-------------------
All files               |     100 |    99.29 |     100 |     100 |
 src                    |     100 |    98.87 |     100 |     100 |
  ValidationCache.js    |     100 |      100 |     100 |     100 |
  context.js            |     100 |      100 |     100 |     100 |
  errors.js             |     100 |      100 |     100 |     100 |
  ims.js                |     100 |      100 |     100 |     100 |
  index.js              |     100 |      100 |     100 |     100 |
  token-helper.js       |     100 |    96.77 |     100 |     100 | 153
 src/ctx                |     100 |      100 |     100 |     100 |
  ConfigCliContext.js   |     100 |      100 |     100 |     100 |
  Context.js            |     100 |      100 |     100 |     100 |
  StateActionContext.js |     100 |      100 |     100 |     100 |
------------------------|---------|----------|---------|---------|-------------------
Jest: "global" coverage threshold for branches (100%) not met: 99.29%

[kwin]

@jsedding Any chance for increasing the code coverage in order to unblock adobe/aio-cli-plugin-aem-rde#97?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bb41343) to head (5348a65).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          488       490    +2     
  Branches        68        69    +1     
=========================================
+ Hits           488       490    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RemoLiechti]

I have added a testcase where no local flag is passed so the default to false assignment is triggered, the coverage is now back to 100%.

[shazron]

This will be released as 7.1.0

[jsedding]

Thanks @RemoLiechti for completing the coverage, and thanks @shazron and @amulyakashyap09 for accepting this PR!

[shazron]

Sorry, it's actually released now as 7.0.2 https://github.com/adobe/aio-lib-ims/releases/tag/7.0.2

[shazron]

Reinstalling the cli might not pick up the changes according to my testing, please uninstall first: npm un -g @adobe/aio-cli

[RemoLiechti]

Shaz, thank you very much! I will test this today and come back to you.