Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove isv dev details from mesh config while packing #716

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

MichaelGoberling
Copy link
Contributor

Description

This PR removes application developer details from the meshConfig portion of deploy.yaml, generated when the developer runs aio app pack

The api-mesh get command returns information about the application developer, which can be omitted from deploy.yaml since a new mesh config can be created with only the data in the meshConfig key

{
  "lastUpdated": "2023-08-29T16:20:01.202Z",
  "meshConfig": {
    "sources": [
      {
        "name": "Commerce",
        "handler": {
          "graphql": {
            "endpoint": "https://venia.magento.com/graphql/"
          }
        }
      }
    ]
  },
  "meshId": "ee487aab-e92e-4035-a757-e18858ef7a92",
  "lastUpdatedBy": {
    "firstName": "Michael",
    "lastName": "Goberling",
    "userEmail": "[email protected]",
    "userId": "4E561E5C62E3F21E0A494122@AdobeID",
    "displayName": "Michael%20Goberling"
  },
  "meshStatus": "success",
  "meshURL": ""
}

Related Issue

Motivation and Context

Security

How Has This Been Tested?

npm run test, locally linked plugin

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #716 (e346e45) into master (682f103) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #716   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3199      3199           
  Branches       603       603           
=========================================
  Hits          3199      3199           
Files Changed Coverage Δ
src/commands/app/pack.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MichaelGoberling MichaelGoberling merged commit 0b7d887 into master Sep 5, 2023
7 checks passed
@MichaelGoberling MichaelGoberling deleted the no-dev-details-mesh-config branch September 5, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants