Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staging -> main (core-v3.2.0) #717

Merged
merged 12 commits into from
Oct 1, 2024
Merged

staging -> main (core-v3.2.0) #717

merged 12 commits into from
Oct 1, 2024

Conversation

praveek
Copy link
Contributor

@praveek praveek commented Oct 1, 2024

  • Added new constants to AEPError.
  • Added the SuppressedByAppDeveloper constant to indicate that the in-app message was not displayed because it was rejected by the app developer via the PresentationDelegate.

rymorale and others added 12 commits September 24, 2024 09:40
- rename DelegateGateNotMet` to `SuppressedByAppDeveloper`.
- update conflict and suppressed by app developer error reasons to match the ones in-use in the iOS core
add `SuppressedByAppDeveloper` to `PresentationError` interface
the coroutine children cancellation was causing all other coroutines other than the first to be cancelled early. this led to some race condition like behavior when determining if a presentable conflict had occurred. removing the children cancellation should have no effect on the event handling done in the `DefaultInAppMessageEventHandler`.
remove cancellation of coroutine children
dev -> staging (core-v3.2.0)
@praveek praveek requested review from prudrabhat and rymorale October 1, 2024 19:42
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.27%. Comparing base (4451e75) to head (78b9713).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
.../marketing/mobile/services/ui/PresentationError.kt 66.67% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4451e75) and HEAD (78b9713). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4451e75) HEAD (78b9713)
functional-tests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               main     #717       +/-   ##
=============================================
- Coverage     81.68%   69.27%   -12.41%     
+ Complexity     2152     1951      -201     
=============================================
  Files           192      192               
  Lines          8975     8981        +6     
  Branches       1125     1125               
=============================================
- Hits           7331     6221     -1110     
- Misses         1086     2293     +1207     
+ Partials        558      467       -91     
Flag Coverage Δ
functional-tests ?
unit-tests 69.27% <88.89%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...in/java/com/adobe/marketing/mobile/AdobeError.java 85.71% <100.00%> (+5.71%) ⬆️
...adobe/marketing/mobile/services/ui/Presentation.kt 88.89% <ø> (ø)
...keting/mobile/services/ui/common/AEPPresentable.kt 94.74% <100.00%> (+0.03%) ⬆️
...ices/ui/message/DefaultInAppMessageEventHandler.kt 78.57% <ø> (-0.30%) ⬇️
.../marketing/mobile/services/ui/PresentationError.kt 83.33% <66.67%> (-16.67%) ⬇️

... and 39 files with indirect coverage changes

@praveek praveek merged commit d3e61e6 into main Oct 1, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants