fix dialog on touch event logic

adobe · Nov 14, 2023 · 4e9c1e5 · 4e9c1e5
1 parent e1043d6
commit 4e9c1e5
Showing 1 changed file with 17 additions and 19 deletions.
diff --git a/code/core/src/phone/java/com/adobe/marketing/mobile/services/ui/MessageFragment.java b/code/core/src/phone/java/com/adobe/marketing/mobile/services/ui/MessageFragment.java
@@ -210,30 +210,28 @@ public boolean onTouchEvent(@NonNull final MotionEvent motionEvent) {
                 if (!uiTakeoverEnabled) {
                     // only log action up or down events as this logging can get quite
                     // spammy
-                    if (motionEvent.getAction() == MotionEvent.ACTION_DOWN
-                            || motionEvent.getAction() == MotionEvent.ACTION_UP) {
+                    if (motionEvent.getAction() == MotionEvent.ACTION_UP) {
                         Log.trace(
                                 ServiceConstants.LOG_TAG,
                                 TAG,
-                                "UI takeover is false, passing the %s event to the parent"
-                                        + " activity.",
-                                MotionEvent.actionToString(motionEvent.getAction()));
+                                "UI takeover is false, passing the touch event to the parent"
+                                        + " activity.");
+                    }
+                    return parentActivity.dispatchTouchEvent(motionEvent);
+                } else {
+                    // load any behavior url strings on action up only as a touch consists of
+                    // two motion events: an action down and an action up event
+                    if (motionEvent.getAction() == MotionEvent.ACTION_UP) {
+                        Log.trace(
+                                ServiceConstants.LOG_TAG,
+                                TAG,
+                                "UI takeover is true, parent activity UI is inaccessible."
+                                        + " Processing defined background tap behaviors.");
+                        webViewGestureListener.handleGesture(MessageGesture.BACKGROUND_TAP);
+                        return true;
                     }
-                    parentActivity.dispatchTouchEvent(motionEvent);
-                    return false;
-                }
-
-                // load any behavior url strings on action up only as a touch consists of
-                // two motion events: an action down and an action up event
-                if (motionEvent.getAction() == MotionEvent.ACTION_UP) {
-                    Log.trace(
-                            ServiceConstants.LOG_TAG,
-                            TAG,
-                            "UI takeover is true, parent activity UI is inaccessible. Processing"
-                                    + " defined background tap behaviors.");
-                    webViewGestureListener.handleGesture(MessageGesture.BACKGROUND_TAP);
                 }
-                return false;
+                return super.onTouchEvent(motionEvent);
             }
         };
     }