Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced hard-coded children with :has(ul) #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jfoxx
Copy link

@jfoxx jfoxx commented Oct 18, 2024

Description

Fixes issue: 107
#107

The main nav shows one dropdown item that is hardcoded in the CSS to only allow the second child to have a dropdown. By changing the selector to :has(ul) it shows the dropdown for any nav item that has children

Related Issue

#107

Motivation and Context

The main nav can only have one dropdown as it is, that is the second child. This fixes it so any item can have a dropdown.

How Has This Been Tested?

I tested only on my own instance with a site derived from this template.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jfoxx jfoxx changed the title replaced hard-coded children with has:(ul) replaced hard-coded children with :has(ul) Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant