-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SITES-21706 Cleanup fastly smartcrop code from core-components repo #2781
base: main
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2781 +/- ##
============================================
- Coverage 87.17% 87.17% -0.01%
+ Complexity 2683 2676 -7
============================================
Files 235 233 -2
Lines 7166 7141 -25
Branches 1094 1092 -2
============================================
- Hits 6247 6225 -22
+ Misses 363 362 -1
+ Partials 556 554 -2 ☔ View full report in Codecov by Sentry. |
We recently introduced support for sensei based smartcrop in core components and we no longer support fastly based smartcrop which was introduced last year. This PR intends to cleanup the code for fastly based smartcrop. @vladbailescu , @LSantha Please note removal of an exported API package in this PR. I am not sure if it is recommended to remove the API or not. Considering that the API package only contained 1 class and that too should ideally not be of any use to customers, I think it is safe to delete it altogether. If you feel and advice otherwise then I can follow the conventional method of deprecating the API and throwing the exception from the implementation. |
do we need to remove the following from the
|
nevermind - was looking at an older version of WCM Core, I see this was already removed in eedb92c |
Fixes #1, Fixes #2