Adobe/dev to master #948
Closed
Adobe/dev to master #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update af-core version * Fixed test cases
* FORMS-3696 adding rich text support for labels FORMS-3696 adding rich text support for labels Co-authored-by: Shivam Agarwal <[email protected]> * FORMS-3696 adding test for deprecated method * FORMS-3696 adding inline editor logic * FORMS-3696 addressed review comments * FORMS-3696 sorting options constraint * FORMS-3696 adding some more test cases --------- Co-authored-by: Shivam Agarwal <[email protected]>
* fix multiple form embedded issue in site page * add repeatability test --------- Co-authored-by: Amit Kumar <[email protected]>
* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case --------- Co-authored-by: Shivam Agarwal <[email protected]>
* Terms and Conditions Terms and Conditions Component Terms and Conditions Component Terms and Conditions component Terms and conditions: code formatting and readme Terms and conditions tooltip Terms and conditions review comments Terms and conditions review comments Terms and Conditions Test Case Fix Terms and Conditions added new tests Terms and Conditions review comments Terms and Conditions component * Terms and Conditions * Terms and Conditions * Terms and conditions: Rich Text Support * Terms and conditions: bump model version --------- Co-authored-by: barshatr <[email protected]>
Co-authored-by: barshatr <[email protected]>
Co-authored-by: Shivam Agarwal <[email protected]>
Co-authored-by: barshatr <[email protected]>
* Added Switch component and resolved PR comments * Resolved PR comments Abstracted nitialize common logic for switch and checkbox Added test cases Fixed bug with enableUncheckedValue sync after save updated js docs and java docs fixed bem updated abstraction logic for switch and checkbox * skipped temporarily tests due to dialog bugs * Refactored code. ternery operator instead of if else fixed bem fixed flaky tests bumped package-info version * FORMS-11284 fixing enum name display on hide (#911) * FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case Co-authored-by: Shivam Agarwal <[email protected]> --------- Co-authored-by: Gulshan Mishra <[email protected]> Co-authored-by: Shivam Agarwal <[email protected]> Co-authored-by: Shivam Agarwal <[email protected]>
* FORMS-10078: updated default pattern to align with v1 * FORMS-10078: resolved PR comments --------- Co-authored-by: Gulshan Mishra <[email protected]>
* Supporting qualified name for accordion, wizard, panel etc * Supporting more core components * Tests for qualified name * Supporting qualified name for accordion, wizard, panel etc * Supporting more core components * Tests for qualified name * Removing jquery from qualified name hook * Enabling other tests for qualified name * Button component support * Alternate way of handling async call to allow sites use case to work * Unclean - tried to re-use sites tests * Tests with sites * Fixing flaky tests * Updated aem-forms-sdk-api version after public release * Fixed typo in test case * Updated test with addon check
Co-authored-by: Pankaj Girotra <[email protected]>
Example Canvas Themes for CheckbBox and TermsAndConditions
… 'setFocus' is triggered on the Text Component. (#920) * FORMS-11276 : Added scroll feature after setFocus * FORMS-11276 : new file added for testcase * FORMS-11276 : changes due to test cases failure * FORMS-11276 : form added
Co-authored-by: barshatr <[email protected]>
Co-authored-by: Gulshan Mishra <[email protected]>
Co-authored-by: Shivam Agarwal <[email protected]>
Co-authored-by: Gulshan Mishra <[email protected]>
Co-authored-by: Shivam Agarwal <[email protected]>
Co-authored-by: Gulshan Mishra <[email protected]>
* all the components were getting scrolled when clicked, fix * setfocus fix on view layer for checkboxgroup and radio buttons --------- Co-authored-by: barshatr <[email protected]>
revert switch component
|
Closing for now, waiting for some fixes in dev |
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: