Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag and drop feature in file input #935

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ private FormConstants() {
/** The resource type for file input v1 */
public static final String RT_FD_FORM_FILE_INPUT_V1 = RT_FD_FORM_PREFIX + "fileinput/v1/fileinput";

/** The resource type for file input v2 */
public static final String RT_FD_FORM_FILE_INPUT_V2 = RT_FD_FORM_PREFIX + "fileinput/v2/fileinput";

/** The resource type for check box group v1 */
public static final String RT_FD_FORM_CHECKBOX_GROUP_V1 = RT_FD_FORM_PREFIX + "checkboxgroup/v1/checkboxgroup";

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
/*
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
* ~ Copyright 2023 Adobe
* ~
* ~ Licensed under the Apache License, Version 2.0 (the "License");
* ~ you may not use this file except in compliance with the License.
* ~ You may obtain a copy of the License at
* ~
* ~ http://www.apache.org/licenses/LICENSE-2.0
* ~
* ~ Unless required by applicable law or agreed to in writing, software
* ~ distributed under the License is distributed on an "AS IS" BASIS,
* ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* ~ See the License for the specific language governing permissions and
* ~ limitations under the License.
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
*/

package com.adobe.cq.forms.core.components.internal.models.v2.form;

import java.util.Map;

import org.apache.sling.api.SlingHttpServletRequest;
import org.apache.sling.api.resource.Resource;
import org.apache.sling.models.annotations.Default;
import org.apache.sling.models.annotations.Exporter;
import org.apache.sling.models.annotations.Model;
import org.apache.sling.models.annotations.injectorspecific.InjectionStrategy;
import org.apache.sling.models.annotations.injectorspecific.ValueMapValue;
import org.jetbrains.annotations.NotNull;

import com.adobe.cq.export.json.ComponentExporter;
import com.adobe.cq.export.json.ExporterConstants;
import com.adobe.cq.forms.core.components.internal.form.FormConstants;
import com.adobe.cq.forms.core.components.internal.models.v1.form.FileInputImpl;
import com.adobe.cq.forms.core.components.models.form.FileInput;
import com.fasterxml.jackson.annotation.JsonIgnore;

@Model(
adaptables = { SlingHttpServletRequest.class, Resource.class },
adapters = { FileInput.class,
ComponentExporter.class },
resourceType = { FormConstants.RT_FD_FORM_FILE_INPUT_V2 })
@Exporter(name = ExporterConstants.SLING_MODEL_EXPORTER_NAME, extensions = ExporterConstants.SLING_MODEL_EXTENSION)
public class FileInputImplV2 extends FileInputImpl {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implements FileInput

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need fileinputimpl with one extra property that why extended the FileInputImpl. Should I write whole FileInputImplV2 similar to FileInputImpl by implementing FileInput and then adding my properties above that?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to extend the base implementation, but adding an explicit implements makes the code more readable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CWIIW but as FileInputImplV2 is extending the FileInputImpl which is already implementing the FileInput hence its not requried to implement in V2 as well.


private static final String DRAG_DROP_TEXT = "dragDropText";

@ValueMapValue(injectionStrategy = InjectionStrategy.OPTIONAL, name = "dragDropText")
@Default(values = FileInput.DEFAULT_DRAGDROP_TEXT)
protected String dragDropText;

@JsonIgnore
public String getDragDropText() {
return dragDropText;
}

@Override
public @NotNull Map<String, Object> getProperties() {
Map<String, Object> customProperties = super.getProperties();
customProperties.put(DRAG_DROP_TEXT, getDragDropText());
return customProperties;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
public interface FileInput extends Field, FileConstraint, ContainerConstraint {
String DEFAULT_BUTTON_TEXT = "Attach";

String DEFAULT_DRAGDROP_TEXT = "Drag and Drop To Upload";

/**
* Returns {@code true} if multiple files can be selected, {@code false} otherwise
*
Expand Down
Loading