Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added theme for aem corecomponents.dev #931

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

egmox
Copy link
Contributor

@egmox egmox commented Oct 16, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@egmox egmox requested a review from amit-mnnit October 16, 2023 11:37
@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 90 100 100 73

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #931 (7b5a231) into dev (80d54f6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #931   +/-   ##
=========================================
  Coverage     80.56%   80.56%           
  Complexity      735      735           
=========================================
  Files            91       91           
  Lines          2048     2048           
  Branches        271      271           
=========================================
  Hits           1650     1650           
  Misses          248      248           
  Partials        150      150           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rismehta rismehta merged commit 3c45dde into dev Oct 17, 2023
10 checks passed
@rismehta rismehta deleted the switch_example_themes branch October 17, 2023 05:27
barshat7 pushed a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants