fixed switch rich text issue #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egmox
force-pushed
the
FORMS-11386-rich_text_issue
branch
from
2756479
to
8ce57c9
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
egmox
force-pushed
the
FORMS-11386-rich_text_issue
branch
from
8ce57c9
to
cdff890
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
egmox
force-pushed
the
FORMS-11386-rich_text_issue
branch
from
cdff890
to
62b73ff
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
Codecov Report
@@ Coverage Diff @@
## dev #929 +/- ##
=========================================
Coverage 80.56% 80.56%
Complexity 735 735
=========================================
Files 91 91
Lines 2048 2048
Branches 271 271
=========================================
Hits 1650 1650
Misses 248 248
Partials 150 150 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rismehta
reviewed
Oct 16, 2023
...nt/jcr_root/apps/core/fd/components/form/switch/v1/switch/clientlibs/editor/js/editDialog.js
Outdated
Show resolved
Hide resolved
rismehta
requested changes
Oct 16, 2023
egmox
force-pushed
the
FORMS-11386-rich_text_issue
branch
from
62b73ff
to
a8080aa
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: