FORMS-11284 fixing enum name display on hide #911

im-shiv · 2023-10-09T08:44:34Z

No description provided.

adobe-bot · 2023-10-09T09:03:54Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2023-10-09T09:03:54Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	90	100	100	73

adobe-bot · 2023-10-09T09:04:06Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

codecov · 2023-10-09T09:08:39Z

Codecov Report

Merging #911 (4f3eb64) into dev (cc27b26) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #911   +/-   ##
=========================================
  Coverage     80.16%   80.16%           
  Complexity      718      718           
=========================================
  Files            88       88           
  Lines          2032     2032           
  Branches        269      269           
=========================================
  Hits           1629     1629           
  Misses          254      254           
  Partials        149      149

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

rismehta · 2023-10-09T11:25:19Z

...ontent/jcr_root/apps/core/fd/components/form/base/v1/base/clientlibs/editor/js/editDialog.js

@@ -298,7 +299,7 @@
        channel.on("click", BASE_ENUM_MULTIFIELD_ADD_BUTTON, function (e) {
            let areOptionsRichText = $(BASE_ARE_OPTIONS_RICH_TEXT)[0],
                enumNames = $(BASE_ENUMNAMES_VISIBLE),
-                richTextEnumNames = $(BASE_WRAPPER_INPUT_RICH_TEXT_ENUMNAMES);
+                richTextEnumNames = $(BASE_RICH_TEXT_ENUMNAMES);


Please write a test case for this use-case.

rismehta

check comments

adobe-bot · 2023-10-09T12:39:34Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2023-10-09T12:39:34Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	88	100	100	73

adobe-bot · 2023-10-09T12:39:46Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case Co-authored-by: Shivam Agarwal <[email protected]> removed unwanted comment

* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case Co-authored-by: Shivam Agarwal <[email protected]>

* Added Switch component and resolved PR comments * Resolved PR comments Abstracted nitialize common logic for switch and checkbox Added test cases Fixed bug with enableUncheckedValue sync after save updated js docs and java docs fixed bem updated abstraction logic for switch and checkbox * skipped temporarily tests due to dialog bugs * Refactored code. ternery operator instead of if else fixed bem fixed flaky tests bumped package-info version * FORMS-11284 fixing enum name display on hide (#911) * FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case Co-authored-by: Shivam Agarwal <[email protected]> --------- Co-authored-by: Gulshan Mishra <[email protected]> Co-authored-by: Shivam Agarwal <[email protected]> Co-authored-by: Shivam Agarwal <[email protected]>

* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case --------- Co-authored-by: Shivam Agarwal <[email protected]>

* Added Switch component and resolved PR comments * Resolved PR comments Abstracted nitialize common logic for switch and checkbox Added test cases Fixed bug with enableUncheckedValue sync after save updated js docs and java docs fixed bem updated abstraction logic for switch and checkbox * skipped temporarily tests due to dialog bugs * Refactored code. ternery operator instead of if else fixed bem fixed flaky tests bumped package-info version * FORMS-11284 fixing enum name display on hide (#911) * FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case Co-authored-by: Shivam Agarwal <[email protected]> --------- Co-authored-by: Gulshan Mishra <[email protected]> Co-authored-by: Shivam Agarwal <[email protected]> Co-authored-by: Shivam Agarwal <[email protected]>

* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case --------- Co-authored-by: Shivam Agarwal <[email protected]>

* Added Switch component and resolved PR comments * Resolved PR comments Abstracted nitialize common logic for switch and checkbox Added test cases Fixed bug with enableUncheckedValue sync after save updated js docs and java docs fixed bem updated abstraction logic for switch and checkbox * skipped temporarily tests due to dialog bugs * Refactored code. ternery operator instead of if else fixed bem fixed flaky tests bumped package-info version * FORMS-11284 fixing enum name display on hide (#911) * FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case Co-authored-by: Shivam Agarwal <[email protected]> --------- Co-authored-by: Gulshan Mishra <[email protected]> Co-authored-by: Shivam Agarwal <[email protected]> Co-authored-by: Shivam Agarwal <[email protected]>

This reverts commit 08189ee.

* Revert "FORMS-11402 fixing initial rte value copying" This reverts commit 80e690b. * Revert "FORMS-11340 adding locale test case for rich text (#918)" This reverts commit 5775ec0. * Revert "FORMS-11284 fixing enum name display on hide (#911)" This reverts commit 08189ee. * Revert "FORMS-3696 adding rich text support for labels (#904)" This reverts commit 6b84a82. * rte-revet fixed test case for tnc * Revert Rich Text: TnC test case fix * Revert Rich Text: TnC test case fix

rismehta reviewed Oct 9, 2023

View reviewed changes

rismehta requested changes Oct 9, 2023

View reviewed changes

Shivam Agarwal added 2 commits October 9, 2023 12:18

FORMS-11284 fixing enum name display on hide

9a25ccf

FORMS-11284 adding test case

4f3eb64

github-actions bot force-pushed the FORMS-11284 branch from db84419 to 4f3eb64 Compare October 9, 2023 12:18

im-shiv requested a review from rismehta October 9, 2023 12:39

rismehta merged commit 08189ee into dev Oct 9, 2023
9 checks passed

rismehta deleted the FORMS-11284 branch October 9, 2023 13:07

egmox pushed a commit that referenced this pull request Oct 10, 2023

FORMS-11284 fixing enum name display on hide (#911)

dd5d609

* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case Co-authored-by: Shivam Agarwal <[email protected]> removed unwanted comment

egmox pushed a commit that referenced this pull request Oct 10, 2023

FORMS-11284 fixing enum name display on hide (#911)

4f3862b

* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case Co-authored-by: Shivam Agarwal <[email protected]>

egmox pushed a commit that referenced this pull request Oct 10, 2023

FORMS-11284 fixing enum name display on hide (#911)

a2921b6

* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case Co-authored-by: Shivam Agarwal <[email protected]>

egmox pushed a commit that referenced this pull request Oct 10, 2023

FORMS-11284 fixing enum name display on hide (#911)

7093cf4

* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case Co-authored-by: Shivam Agarwal <[email protected]>

egmox pushed a commit that referenced this pull request Oct 10, 2023

FORMS-11284 fixing enum name display on hide (#911)

a7d770e

* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case Co-authored-by: Shivam Agarwal <[email protected]>

egmox pushed a commit that referenced this pull request Oct 10, 2023

FORMS-11284 fixing enum name display on hide (#911)

2c2711f

* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case Co-authored-by: Shivam Agarwal <[email protected]>

egmox pushed a commit that referenced this pull request Oct 10, 2023

FORMS-11284 fixing enum name display on hide (#911)

bf388e1

* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case Co-authored-by: Shivam Agarwal <[email protected]>

egmox pushed a commit that referenced this pull request Oct 10, 2023

FORMS-11284 fixing enum name display on hide (#911)

d715a6f

* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case Co-authored-by: Shivam Agarwal <[email protected]>

barshat7 pushed a commit that referenced this pull request Oct 13, 2023

FORMS-11284 fixing enum name display on hide (#911)

05bfef8

* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case --------- Co-authored-by: Shivam Agarwal <[email protected]>

barshat7 pushed a commit that referenced this pull request Oct 13, 2023

FORMS-11284 fixing enum name display on hide (#911)

6211ea7

* FORMS-11284 fixing enum name display on hide * FORMS-11284 adding test case --------- Co-authored-by: Shivam Agarwal <[email protected]>

barshat7 added a commit that referenced this pull request Nov 2, 2023

Revert "FORMS-11284 fixing enum name display on hide (#911)"

3c90b4c

This reverts commit 08189ee.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FORMS-11284 fixing enum name display on hide #911

FORMS-11284 fixing enum name display on hide #911

im-shiv commented Oct 9, 2023

adobe-bot commented Oct 9, 2023

adobe-bot commented Oct 9, 2023

adobe-bot commented Oct 9, 2023

codecov bot commented Oct 9, 2023 •

edited

Loading

rismehta Oct 9, 2023

im-shiv Oct 9, 2023

rismehta left a comment

adobe-bot commented Oct 9, 2023

adobe-bot commented Oct 9, 2023

adobe-bot commented Oct 9, 2023

FORMS-11284 fixing enum name display on hide #911

FORMS-11284 fixing enum name display on hide #911

Conversation

im-shiv commented Oct 9, 2023

adobe-bot commented Oct 9, 2023

Lighthouse scores (desktop)

adobe-bot commented Oct 9, 2023

Lighthouse scores (mobile)

adobe-bot commented Oct 9, 2023

Accessibility Violations Found

codecov bot commented Oct 9, 2023 • edited Loading

Codecov Report

rismehta Oct 9, 2023

Choose a reason for hiding this comment

im-shiv Oct 9, 2023

Choose a reason for hiding this comment

rismehta left a comment

Choose a reason for hiding this comment

adobe-bot commented Oct 9, 2023

Lighthouse scores (desktop)

adobe-bot commented Oct 9, 2023

Lighthouse scores (mobile)

adobe-bot commented Oct 9, 2023

Accessibility Violations Found

codecov bot commented Oct 9, 2023 •

edited

Loading