Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to Master #897

Closed
wants to merge 10 commits into from
Closed

Dev to Master #897

wants to merge 10 commits into from

Conversation

dmaurya929
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

demaurya and others added 10 commits September 1, 2023 18:07
* FORMS-10956 | posting accessibility table

* FORMS-10956| fixing TEST_EXECUTED check

* FORMS-10956 | post comment fix

* FORMS-10956 | post comment fix

* FORMS-10956 | adding node index to avoid multiple pr comments

* FORMS-10956 | format fix git comment

---------

Co-authored-by: PRATEEK AWASTHI <[email protected]>
Co-authored-by: PRATEEK AWASTHI <[email protected]>
* [FORMS-10944] update filled/empty class

* fix selector for telephone label

* add filled/empty test cases

* add test cases

* add data-cmp-required & data-cmp-readonly attribute

* add test cases

---------

Co-authored-by: Amit Kumar <[email protected]>
* FORMS-10419: bug fix

* FORMS-10419: test case added, for clear option functioning after applying formatters

* FORMS-10419: updated the test case

* incorporated review comment

* FORMS-10419: fix the datepicker-calendar-icon as per BEM

* FORMS-10419: minor fix

* updated missing semi-colon
Parent element have same classes for some components
* FORMS-9362: loading icon behind fields

* FORMS-9362 : null check added as per comments

* FORMS-9362 : changes due to review comments

* FORMS-9362 : formatting the changes
* FORMS-3342 : editElementQuery changes as span

* FORMS-3342 : added the test cases

* FORMS-3342 : test case editted

* FORMS-3342 : changes due to review commits

* FORMS-3342 : changes due to
@rismehta
Copy link
Collaborator

Please create a separate branch from dev and then create a PR

@dmaurya929 dmaurya929 closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants