FORMS-3696 adding rich text support for labels #888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
Codecov Report
@@ Coverage Diff @@
## dev #888 +/- ##
============================================
- Coverage 80.07% 79.77% -0.31%
Complexity 714 714
============================================
Files 87 88 +1
Lines 2023 2032 +9
Branches 269 269
============================================
+ Hits 1620 1621 +1
- Misses 254 262 +8
Partials 149 149
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
|
old PR and discussion for reference: #623 |
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
rismehta
requested changes
Sep 29, 2023
| @@ -95,15 +100,23 @@ public Object[] getEnums() { | |||
| } | |||
|
|
|||
| @Override | |||
| public String[] getEnumNames() { | |||
| public RichText[] getEnumNames() { | |||
There was a problem hiding this comment.
You just can't change public API syntax, please mark this as deprecated and introduce a new API. This would break existing customer forms.
There was a problem hiding this comment.
how would it break existing customer forms?
| */ | ||
| String[] getEnumNames(); | ||
| RichText[] getEnumNames(); |
There was a problem hiding this comment.
This can't be changed since it already exposed, mark it as deprecate and introduce a new function. Please mention in the new function, that this is introduced since which version based on package-info and only bump the major version
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
* FORMS-9362: loading icon behind fields * FORMS-9362 : null check added as per comments * FORMS-9362 : changes due to review comments * FORMS-9362 : formatting the changes
* FORMS-3342 : editElementQuery changes as span * FORMS-3342 : added the test cases * FORMS-3342 : test case editted * FORMS-3342 : changes due to review commits * FORMS-3342 : changes due to
* Update af-core version * Fixed test cases
# Conflicts: # ui.tests/test-module/specs/button/button.authoring.spec.js
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.