Forms-3342 editElementQuery changes as span #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
FORMS-3342
branch
from
cdd104e
to
355df19
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
Codecov Report
@@ Coverage Diff @@
## dev #883 +/- ##
=========================================
Coverage 80.07% 80.07%
Complexity 714 714
=========================================
Files 87 87
Lines 2023 2023
Branches 269 269
=========================================
Hits 1620 1620
Misses 254 254
Partials 149 149 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rismehta
reviewed
Sep 25, 2023
| $span[0].textContent = ''; | ||
| }); | ||
| cy.get('body').click( 0,0); | ||
| cy.get('span.sidepanel-tree-item-label label.name').as('labelElement'); |
There was a problem hiding this comment.
Can we have a better CSS selector for this ? Are these CSS classes public ?
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
im-shiv
pushed a commit
that referenced
this pull request
Oct 3, 2023
* FORMS-3342 : editElementQuery changes as span * FORMS-3342 : added the test cases * FORMS-3342 : test case editted * FORMS-3342 : changes due to review commits * FORMS-3342 : changes due to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the editElementQuery was label initially but in button it should be span as we have used span for the title in place of label
added the necessary test cases for the particular change.
Related Issue
FORMS-3342 Title issue is while inline editing the title for Button, Reset and Submit button.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: