FORMS-9362: loading icon behind fields #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #880 +/- ##
=========================================
Coverage 80.07% 80.07%
Complexity 714 714
=========================================
Files 87 87
Lines 2023 2023
Branches 269 269
=========================================
Hits 1620 1620
Misses 254 254
Partials 149 149 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Test cases were already present in command.js therefore, I have updated the test case according to the latest code. |
AnurudraS
commented
Sep 18, 2023
There was a problem hiding this comment.
Test cases were already present in command.js therefore, I have updated the test case according to the latest code.
rismehta
reviewed
Sep 21, 2023
.../apps/core/fd/components/form/container/v2/container/clientlibs/site/js/formcontainerview.js
Outdated
Show resolved
Hide resolved
rismehta
reviewed
Sep 21, 2023
.../apps/core/fd/components/form/container/v2/container/clientlibs/site/js/formcontainerview.js
Show resolved
Hide resolved
github-actions
bot
force-pushed
the
FORMS_9362
branch
from
68e8f5d
to
6454483
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
rismehta
reviewed
Sep 22, 2023
| @@ -63,14 +63,20 @@ | |||
| const startTime = new Date().getTime(); | |||
| let elements = document.querySelectorAll(FormContainerV2.selectors.self); | |||
| for (let i = 0; i < elements.length; i++) { | |||
| elements[i].classList.add(FormContainerV2.loadingClass); | |||
| let loaderToAdd = document.querySelector("[data-cmp-adaptiveform-container-loader='"+ elements[i].id + "']"); | |||
| if(loaderToAdd){ | |||
There was a problem hiding this comment.
Please fix formatting here
rismehta
requested changes
Sep 22, 2023
github-actions
bot
force-pushed
the
FORMS_9362
branch
from
8aab3ae
to
357ff87
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
im-shiv
pushed a commit
that referenced
this pull request
Oct 3, 2023
* FORMS-9362: loading icon behind fields * FORMS-9362 : null check added as per comments * FORMS-9362 : changes due to review comments * FORMS-9362 : formatting the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed with Rishi, the sibling div should have the selector as the ID of form and selecting the div with the same and adding the loading class on it later removing as well with the same steps.
However the test cases were already written in command.js file therefore, I have made the corrections in the same for the updated logic.
the new updates has been added to the readme file as well.
Related Issue
FORMS-9362: Loading Icon Behind Fields
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: