Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Next and Back Button core-components #869

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from
Open

Added Next and Back Button core-components #869

wants to merge 22 commits into from

Conversation

ravise5
Copy link
Contributor

@ravise5 ravise5 commented Sep 11, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

.gitignore Outdated Show resolved Hide resolved
@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 100 100 73

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #869 (8142162) into dev (ff965f1) will decrease coverage by 0.16%.
Report is 6 commits behind head on dev.
The diff coverage is 0.00%.

❗ Current head 8142162 differs from pull request most recent head 791db0d. Consider uploading reports for the commit 791db0d to get more accurate results

@@             Coverage Diff              @@
##                dev     #869      +/-   ##
============================================
- Coverage     80.54%   80.39%   -0.16%     
  Complexity      730      730              
============================================
  Files            90       91       +1     
  Lines          2041     2045       +4     
  Branches        269      269              
============================================
  Hits           1644     1644              
- Misses          248      252       +4     
  Partials        149      149              
Files Coverage Δ
.../components/internal/models/v1/form/PanelImpl.java 93.33% <0.00%> (-3.22%) ⬇️
...mponents/internal/models/v1/form/FormTabsImpl.java 0.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@sakshi-arora1 sakshi-arora1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravise5 see how view adapts to changes in model. Same needs to be done.

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 91 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 88 100 100 73

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate

@ravise5
Copy link
Contributor Author

ravise5 commented Nov 14, 2023

@ravise5 see how view adapts to changes in model. Same needs to be done.

This is already incorporated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants