FORMS-3342 : Title issue is while inline editing the title for Button, Reset and Submit button. #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Codecov Report
@@ Coverage Diff @@
## dev #849 +/- ##
=========================================
Coverage 80.22% 80.22%
Complexity 712 712
=========================================
Files 87 87
Lines 2013 2013
Branches 268 268
=========================================
Hits 1615 1615
Misses 250 250
Partials 148 148 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
devgurjar
reviewed
Sep 5, 2023
| @@ -0,0 +1,32 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <jcr:root xmlns:granite="http://www.adobe.com/jcr/granite/1.0" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" | |||
There was a problem hiding this comment.
Please add copy write header
There was a problem hiding this comment.
is it required here? as I cannot see in other similar files!
copyright header can be only seen in pom.xml and this is editConfig.xml
AnurudraS
changed the title
github-actions
bot
force-pushed
the
FORMS-3342
branch
from
d189f3d
to
a34c0ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The file _cq_editConfig.xml is added to override the inplaceEditingConfig property named editElementQuery.
Currently, the issue is due to the editElementQuery property as it was label:first and no label was defined in button, therefore with this fix the issue is resolved and doesn't impact other components.
Related Issue
FORMS-3342 : Title issue in form authoring with Button, Reset and Submit button.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: