FORMS-10078: updated default pattern to align with v1 #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
rismehta
reviewed
Aug 18, 2023
.../content/jcr_root/apps/forms-components-examples/components/form/emailinput/_cq_template.xml
Show resolved
Hide resolved
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Codecov Report
@@ Coverage Diff @@
## dev #820 +/- ##
=========================================
Coverage 80.16% 80.16%
Complexity 718 718
=========================================
Files 88 88
Lines 2032 2032
Branches 269 269
=========================================
Hits 1629 1629
Misses 254 254
Partials 149 149 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dmaurya929
approved these changes
Sep 8, 2023
egmox
force-pushed
the
FORMS-10078-email-v1-parity
branch
from
d6054ae
to
0c63b77
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
sakshi-arora1
approved these changes
Oct 11, 2023
barshat7
pushed a commit
that referenced
this pull request
Oct 13, 2023
* FORMS-10078: updated default pattern to align with v1 * FORMS-10078: resolved PR comments --------- Co-authored-by: Gulshan Mishra <[email protected]>
barshat7
pushed a commit
that referenced
this pull request
Oct 13, 2023
* FORMS-10078: updated default pattern to align with v1 * FORMS-10078: resolved PR comments --------- Co-authored-by: Gulshan Mishra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: