Add Show Popup property under custom property #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
tnc/add-custom
branch
from
8a84698
to
298329f
Compare
github-actions
bot
force-pushed
the
tnc/add-custom
branch
from
3104ffe
to
9389502
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1437 +/- ##
=========================================
Coverage 82.27% 82.27%
Complexity 923 923
=========================================
Files 103 103
Lines 2369 2370 +1
Branches 321 321
=========================================
+ Hits 1949 1950 +1
Misses 257 257
Partials 163 163 ☔ View full report in Codecov by Sentry. |
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
reviewed
Oct 9, 2024
| @@ -47,7 +47,7 @@ | |||
| "showApprovalOption": true, | |||
| "jcr:title": "Terms And Conditions", | |||
| "fd:tnc": true, | |||
| "showAsPopup": true, | |||
There was a problem hiding this comment.
This is backward incompatible change, for now, let's keep the property in content structure change (ie) showAsPopup so that existing form continue to work
github-actions
bot
force-pushed
the
tnc/add-custom
branch
from
7a0fd27
to
d288a5b
Compare
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
reviewed
Oct 14, 2024
| @@ -9,7 +9,8 @@ | |||
| "dorExcludeDescription": false | |||
| }, | |||
| "fd:path": "/content/termsandconditionsNoWrapData", | |||
| "fd:tnc": true | |||
| "fd:tnc": true, | |||
| "showAsPopup": true | |||
There was a problem hiding this comment.
The exported key should have the fd: prefix. My previous comment referred to the property saved in JCR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: