Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test pr #1429

Merged
merged 3 commits into from
Sep 30, 2024
Merged

test pr #1429

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/exporter-validate-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,17 @@ jobs:
echo "$removed_keys"
exit 1
fi

# Check for changed values
for key in $base_keys; do
base_value=$(echo "$base_file" | jq -r ".$key")
head_value=$(echo "$head_file" | jq -r ".$key")

if [ "$base_value" != "$head_value" ]; then
echo "Backward incompatibility change detected in $file. The value of key '$key' was changed from '$base_value' to '$head_value'."
exit 1
fi
done
done

echo "All exporter JSON files have only additions. No backward incompatibility changes detected."
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/validate-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ jobs:
run: |
# Identify changed test files
changed_test_files=$(git diff --name-only ${{ github.base_ref }} ${{ github.head_ref }} | grep '\.cy\.js$')

# Loop through each changed test file
for file in $changed_test_files; do
# Check if the file contains 'it.only'
if grep -q 'it\.only' "$file"; then
echo "Test file $file contains 'it.only'. This is not allowed."
# Check if the file contains 'it.only', 'describe.skip', or 'it.skip'
if grep -qE 'it\.only|describe\.skip|it\.skip' "$file"; then
echo "Test file $file contains 'it.only', 'describe.skip', or 'it.skip'. This is not allowed."
exit 1
fi
done

echo "No test files contain 'it.only'."
echo "No test files contain 'it.only', 'describe.skip', or 'it.skip'."
shell: bash
Loading