Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch master_260924 #1422

Merged
merged 23 commits into from
Sep 26, 2024
Merged

Merge branch master_260924 #1422

merged 23 commits into from
Sep 26, 2024

Conversation

deepprakash345
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

pavi41 and others added 23 commits September 16, 2024 19:06
* removed wcm mode from the embed container iframe

* removed wcm mode from the embed container iframe II

* wcm mode param remvoed from the embed src

* refactored

* test cases added

* test case fixed

---------

Co-authored-by: Rajat Khurana <[email protected]>
* Flaky test fix

* Skipping flaky test
* @releng latest aem image

* update aem image

* updating wcm component version

* Fixing circle ci config
…odel (#1409)

* FORMS-16011 - Binding each core component's fieldType to its respective sling model.

* fixing import

* Fixing test collateral

* fixing import order

* Fixing star imports

* Refactoring getFieldType to super class

* Updating import

* sorting import

* Spec update to 0.14.1 | RTC approved

* updating classpath with schema folder

* fixing paths

* updating schema with buttonType

* incorporating review comments
* Updating type for buttons

* Updating collateral for button

* Fixing collateral and test

* Fixing code and test

* Fixing test and keeping button disabled

* Adding code comments

* Updating read me and test

* Fixing reset test

---------

Co-authored-by: Muskan Gupta <[email protected]>
Co-authored-by: Muskan Gupta <[email protected]>
Co-authored-by: Rishi Mehta <[email protected]>
@deepprakash345 deepprakash345 merged commit 2172d25 into release/650 Sep 26, 2024
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants