-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge branch master_260924 #1422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pavitra Khatri <[email protected]>
* removed wcm mode from the embed container iframe * removed wcm mode from the embed container iframe II * wcm mode param remvoed from the embed src * refactored * test cases added * test case fixed --------- Co-authored-by: Rajat Khurana <[email protected]>
Dev master17 sep
* Flaky test fix * Skipping flaky test
…dation is complete (#1413)
Co-authored-by: Pavitra Khatri <[email protected]>
…odel (#1409) * FORMS-16011 - Binding each core component's fieldType to its respective sling model. * fixing import * Fixing test collateral * fixing import order * Fixing star imports * Refactoring getFieldType to super class * Updating import * sorting import * Spec update to 0.14.1 | RTC approved * updating classpath with schema folder * fixing paths * updating schema with buttonType * incorporating review comments
* Updating type for buttons * Updating collateral for button * Fixing collateral and test * Fixing code and test * Fixing test and keeping button disabled * Adding code comments * Updating read me and test * Fixing reset test --------- Co-authored-by: Muskan Gupta <[email protected]> Co-authored-by: Muskan Gupta <[email protected]> Co-authored-by: Rishi Mehta <[email protected]>
Co-authored-by: Pavitra Khatri <[email protected]>
Dev master26 sep
jalagari
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: