Dev master26 sep #1420
Merged
Dev master26 sep #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Flaky test fix * Skipping flaky test
…dation is complete (#1413)
Co-authored-by: Pavitra Khatri <[email protected]>
…odel (#1409) * FORMS-16011 - Binding each core component's fieldType to its respective sling model. * fixing import * Fixing test collateral * fixing import order * Fixing star imports * Refactoring getFieldType to super class * Updating import * sorting import * Spec update to 0.14.1 | RTC approved * updating classpath with schema folder * fixing paths * updating schema with buttonType * incorporating review comments
* Updating type for buttons * Updating collateral for button * Fixing collateral and test * Fixing code and test * Fixing test and keeping button disabled * Adding code comments * Updating read me and test * Fixing reset test --------- Co-authored-by: Muskan Gupta <[email protected]> Co-authored-by: Muskan Gupta <[email protected]> Co-authored-by: Rishi Mehta <[email protected]>
Co-authored-by: Pavitra Khatri <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1420 +/- ##
============================================
+ Coverage 82.24% 82.40% +0.15%
- Complexity 902 919 +17
============================================
Files 103 103
Lines 2337 2358 +21
Branches 317 317
============================================
+ Hits 1922 1943 +21
- Misses 254 255 +1
+ Partials 161 160 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: