[Save form] Re-saving of draft creates new draft instead of updating exis… #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1400 +/- ##
============================================
+ Coverage 82.24% 82.27% +0.03%
- Complexity 902 905 +3
============================================
Files 103 103
Lines 2337 2341 +4
Branches 317 319 +2
============================================
+ Hits 1922 1926 +4
Misses 254 254
Partials 161 161 ☔ View full report in Codecov by Sentry. |
girotraapankaj
changed the title
barshat7
reviewed
Sep 17, 2024
.../main/java/com/adobe/cq/forms/core/components/internal/models/v2/form/FormContainerImpl.java
Show resolved
Hide resolved
girotraapankaj
commented
Sep 18, 2024
| if (request != null && StringUtils.isNotBlank(request.getParameter(GuideConstants.AF_DATA_REF))) { | ||
| final String dataRef = request.getParameter(GuideConstants.AF_DATA_REF); | ||
| if (dataRef.startsWith(DRAFT_PREFILL_SERVICE)) { | ||
| properties.put(GuideConstants.DRAFT_ID, StringUtils.substringAfter(dataRef, DRAFT_PREFILL_SERVICE)); |
There was a problem hiding this comment.
this property does not get stored on jcr, it will be added when FP prefill is used.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ting draft
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: