Password comp #1316

devgurjar · 2024-07-11T10:42:25Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

adobe-bot · 2024-07-11T11:04:06Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2024-07-11T11:04:06Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-07-11T11:04:17Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-07-11T11:04:52Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-07-11T11:05:30Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

codecov · 2024-07-11T16:51:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (9ed6529) to head (1943844).

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #1316      +/-   ##
============================================
+ Coverage     82.40%   82.56%   +0.16%     
- Complexity      919      933      +14     
============================================
  Files           103      104       +1     
  Lines          2358     2375      +17     
  Branches        317      319       +2     
============================================
+ Hits           1943     1961      +18     
+ Misses          255      254       -1     
  Partials        160      160

Flag	Coverage Δ
	`82.56% <100.00%> (+0.16%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adobe-bot · 2024-09-04T09:16:44Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-09-04T09:22:05Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	96	96	75

adobe-bot · 2024-09-04T09:22:05Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-09-04T09:22:16Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-09-04T09:22:45Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-09-04T09:22:53Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

rismehta

Can we use the new field type in this PR ? Please sync with talmiz on this

devgurjar · 2024-09-17T06:40:55Z

Can we use the new field type in this PR ? Please sync with talmiz on this

Yes we have used new field type in this PR, please refer to this commit
https://git.corp.adobe.com/livecycle/af2-docs/pull/211/files#diff-a2a39757552dd1988f477b116329eba154e51bff6f2530d575b16fe6c76cd833R192

devgurjar · 2024-09-17T06:47:39Z

For opening and closing eye icon, we have changed code in theme
adobe/aem-forms-theme-canvas@17c7b85

adobe-bot · 2024-09-26T11:45:16Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-09-26T11:50:17Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2024-09-26T11:50:19Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2024-09-26T11:50:43Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	96	96	75

adobe-bot · 2024-09-26T11:50:43Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-09-26T11:50:53Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

* GH actions * Dummy change * dummy * change * Fix error * Fix error * fix error * Fix error * fix regex * Fix code * dummy change * Dummy change * Fix errors

…ck update

Updated Javascript code for toggle password visibility. Html code cleanups

…ct values on view

…and min values update

adobe-bot · 2024-09-30T11:09:41Z

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-09-30T11:12:26Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	96	96	75

adobe-bot · 2024-09-30T11:12:26Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-09-30T11:12:37Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-09-30T11:14:00Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-09-30T11:14:13Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

rismehta

check comments

rismehta · 2024-11-13T08:11:30Z

...f.apps/src/main/content/jcr_root/apps/core/fd/components/form/password/v1/password/README.md

+
+## BEM Description
+```
+BLOCK cmp-adaptiveform-password


This BEM is not complete, please correct the BEM as per the HTML output

rismehta · 2024-11-13T08:12:20Z

...e/src/main/java/com/adobe/cq/forms/core/components/internal/models/v1/form/PasswordImpl.java

+
+    @Override
+    public String getFieldType() {
+        return super.getFieldType();


fieldType function was changed recently, please check the recent implementation, we now return a constant value in fieldType and not rely on JCR anymore (we have a fallback now)

rismehta · 2024-11-13T08:24:09Z

...e/src/main/java/com/adobe/cq/forms/core/components/internal/models/v1/form/PasswordImpl.java

+
+    @ValueMapValue(injectionStrategy = InjectionStrategy.OPTIONAL)
+    @Nullable
+    private String validationPattern;


Please add a test case using validation pattern same for some common customer use-cases (for example) password should contain 2 number, and only some special characters like ! and @

rismehta · 2024-11-13T08:24:54Z

...e/src/main/java/com/adobe/cq/forms/core/components/internal/models/v1/form/PasswordImpl.java

+    }
+
+    @Override
+    public Integer getMinLength() {


Can we create an abstract method and re-use this, looks like it is copy / pasted from TextInput and NumberInput

rismehta · 2024-11-13T08:25:07Z

bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/FieldType.java

@@ -36,6 +36,7 @@ public enum FieldType {
    FORM("form"),
    CHECKBOX_GROUP("checkbox-group"),
    IMAGE("image"),
+


Please revert this

rismehta · 2024-11-13T08:35:46Z

...src/main/content/jcr_root/apps/core/fd/components/form/password/v1/password/_cq_template.xml

+<jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" xmlns:cq="http://www.day.com/jcr/cq/1.0"
+    jcr:primaryType="nt:unstructured"
+    jcr:title="Password"
+    fieldType="password"/>


let's get rid of this

rismehta · 2024-11-13T08:36:53Z

...tent/jcr_root/apps/core/fd/components/form/password/v1/password/clientlibs/site/.content.xml

+    jcr:primaryType="cq:ClientLibraryFolder"
+    allowProxy="{Boolean}true"
+    categories="[core.forms.components.password.v1.runtime]"
+    dependencies="[core.forms.components.runtime.base,core.forms.components.container.v2.runtime]"/>


This should not be dependent on container.v2.runtime, please remove it

rismehta · 2024-11-13T08:39:12Z

...ps/src/main/content/jcr_root/apps/core/fd/components/form/password/v1/password/password.html

+        placeholder="${password.placeHolder}"
+        pattern="${password.validationPattern}" 
+        dir="auto" 
+        aria-label="password" />


Why is aria-label a constant value ?

rismehta · 2024-11-13T08:39:27Z

ui.frontend/src/constants.js

@@ -365,6 +365,6 @@ export const Constants = {
     * Prefix path for all AF HTTP APIs.
     * @type {string}
     */
-    API_PATH_PREFIX : "/adobe/forms/af"
+    API_PATH_PREFIX : "/adobe/forms/af",


unrelated change

rismehta · 2024-11-13T08:39:59Z

ui.tests/test-module/specs/password/password.runtime.spec.js

+        })
+    })
+
+    it("decoration element should not have same class name", () => {


Can we have runtime test using pattern and eye icon, which is pretty common for password field ?

github-actions bot force-pushed the password-comp branch from 68a0423 to 4cd5d24 Compare July 11, 2024 10:42

devgurjar force-pushed the password-comp branch from 4cd5d24 to fdcdfb9 Compare September 4, 2024 08:58

rismehta requested changes Sep 13, 2024

View reviewed changes

rismehta mentioned this pull request Sep 19, 2024

UE: Binding each core component's fieldType to its respective sling model #1409

Merged

10 tasks

devgurjar force-pushed the password-comp branch from 9432b5c to f17a90a Compare September 30, 2024 10:51

rismehta and others added 5 commits September 30, 2024 10:52

GH actions (#1428)

9f82250

* GH actions * Dummy change * dummy * change * Fix error * Fix error * fix error * Fix error * fix regex * Fix code * dummy change * Dummy change * Fix errors

AF Password Component| Updated license year and few code comments blo…

1f107be

…ck update

AF Password Field| Updated Javascript code, updated apps pom.xml.

fd2f21e

Updated Javascript code for toggle password visibility. Html code cleanups

AF Password|Test Cases and html updates supporting responsiveness

162d211

AF Password| Test case updates

a2599ec

kum-sushil added 3 commits September 30, 2024 10:52

AF Password | PR review comments Updates

bd243cc

AF-Password|PR Comments| Removed Constants from FormConstants to dire…

a1cb24b

…ct values on view

AF-password||Resolved test cases and password java for exclusive max …

1943844

…and min values update

github-actions bot force-pushed the password-comp branch from f17a90a to 1943844 Compare September 30, 2024 10:52

rismehta requested changes Nov 13, 2024

View reviewed changes

Password comp #1316

Are you sure you want to change the base?

Password comp #1316

Conversation

devgurjar commented Jul 11, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

adobe-bot commented Jul 11, 2024

Lighthouse scores (mobile)

adobe-bot commented Jul 11, 2024

Lighthouse scores (desktop)

adobe-bot commented Jul 11, 2024

Accessibility Violations Found

adobe-bot commented Jul 11, 2024

Accessibility Violations Found

adobe-bot commented Jul 11, 2024

Accessibility Violations Found

codecov bot commented Jul 11, 2024 • edited Loading

Codecov Report

adobe-bot commented Sep 4, 2024

Accessibility Violations Found

adobe-bot commented Sep 4, 2024

Lighthouse scores (mobile)

adobe-bot commented Sep 4, 2024

Lighthouse scores (desktop)

adobe-bot commented Sep 4, 2024

Accessibility Violations Found

adobe-bot commented Sep 4, 2024

Accessibility Violations Found

adobe-bot commented Sep 4, 2024

Accessibility Violations Found

rismehta left a comment

Choose a reason for hiding this comment

devgurjar commented Sep 17, 2024

devgurjar commented Sep 17, 2024

adobe-bot commented Sep 26, 2024

Accessibility Violations Found

adobe-bot commented Sep 26, 2024

Accessibility Violations Found

adobe-bot commented Sep 26, 2024

Accessibility Violations Found

adobe-bot commented Sep 26, 2024

Lighthouse scores (mobile)

adobe-bot commented Sep 26, 2024

Lighthouse scores (desktop)

adobe-bot commented Sep 26, 2024

Accessibility Violations Found

adobe-bot commented Sep 30, 2024

Accessibility Violations Found

adobe-bot commented Sep 30, 2024

Lighthouse scores (mobile)

adobe-bot commented Sep 30, 2024

Lighthouse scores (desktop)

adobe-bot commented Sep 30, 2024

Accessibility Violations Found

adobe-bot commented Sep 30, 2024

Accessibility Violations Found

adobe-bot commented Sep 30, 2024

Accessibility Violations Found

rismehta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jul 11, 2024 •

edited

Loading