Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master to 650 3 july 24 #1301

Merged
merged 176 commits into from
Jul 10, 2024
Merged

Master to 650 3 july 24 #1301

merged 176 commits into from
Jul 10, 2024

Conversation

barshat7
Copy link
Contributor

@barshat7 barshat7 commented Jul 3, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

barshat7 and others added 30 commits April 15, 2024 08:31
Added condition on description and error message in aria-describedby
* FORMS-12203: Added localization changes and test cases

* FORMS-12203: Updated test case

* FORMS-12203: Altered to contains instead of get

* FORMS-12203: Resolved comments

* FORMS-12203: Updated test cases

* FORMS-12203: Updated delete button

* FORMS-12203: Updated button

* Retry wizard.locale.spec.js tests

* FORMS-12203: Added theme request wait

* Update wizard.locale.spec.js

* Added latestaddon check

* Delete ui.tests/test-module/package-lock.json

* Update commands.js

* Revert "Delete ui.tests/test-module/package-lock.json"

This reverts commit fd97b53.

* Reverted package-lock.json changes

* FORMS-12203: Removed exception inline

* FORMS-12203: Resolved comments

* FORMS-12203: Update index.js

* FORMS-12203: Removed package-lock.json change

* Update index.js

* Update error message in index.js

* Update index.js

* Update wizard.locale.spec.js

* Removed an intercept

* Updated regex patterns

---------

Co-authored-by: Shivangi Mittal <[email protected]>
#1195)

* FORMS-12822 : format should not be visible when no pattern is selected

* FORMS-12822 : format should not be visible when no pattern is selected
… selected (#1195)"

This reverts commit 5c19a652671e4461tbec5a2677e3d918952c9ba67.
* FORMS-13851 Support for language in date picker and number input
@review @vdua
DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
    @review @vdua
    DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
        @review @vdua
        DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
            @review @vdua
            DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
                @review @vdua
                DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
                    @review @vdua
                    DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
                        @review @vdua
                        DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
                            @review @vdua
                            DOD(Yes)

* Update space character for thousands separator in french lang

* FORMS-13851 Support for language in date picker and number input
                                @review @vdua
                                DOD(Yes)

---------

Co-authored-by: Varun Dua <[email protected]>
* FORMS-12203: Added localization changes and test cases

* FORMS-12203: Updated test case

* FORMS-12203: Altered to contains instead of get

* FORMS-12203: Resolved comments

* FORMS-12203: Updated test cases

* FORMS-12203: Updated delete button

* FORMS-12203: Updated button

* Retry wizard.locale.spec.js tests

* FORMS-12203: Added theme request wait

* Update wizard.locale.spec.js

* Added latestaddon check

* Delete ui.tests/test-module/package-lock.json

* Update commands.js

* Revert "Delete ui.tests/test-module/package-lock.json"

This reverts commit fd97b53.

* Reverted package-lock.json changes

* FORMS-12203: Removed exception inline

* FORMS-12203: Resolved comments

* FORMS-12203: Update index.js

* FORMS-12203: Removed package-lock.json change

* Update index.js

* Update error message in index.js

* Update index.js

* Update wizard.locale.spec.js

* Removed an intercept

* Updated regex patterns

---------

Co-authored-by: Shivangi Mittal <[email protected]>
* FORMS-13851 Support for language in date picker and number input
@review @vdua
DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
    @review @vdua
    DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
        @review @vdua
        DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
            @review @vdua
            DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
                @review @vdua
                DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
                    @review @vdua
                    DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
                        @review @vdua
                        DOD(Yes)

* FORMS-13851 Support for language in date picker and number input
                            @review @vdua
                            DOD(Yes)

* Update space character for thousands separator in french lang

* FORMS-13851 Support for language in date picker and number input
                                @review @vdua
                                DOD(Yes)

---------

Co-authored-by: Varun Dua <[email protected]>
#1196)

* FORMS-12822 : format should not be visible when no pattern is selected

* FORMS-12822 : changes var to let as per ES6 in utils.js
…d submit() rule in examples (#1191)

* FORMS-13209: added check to override hardcoded submitSuccess and submitError hadnlers

* FORMS-13209: updated af2 runtime version

* FORMS-13209: added rule editor authoring cypress tests

* FORMS-13209: added submission handler rule tests

* FORMS-13209: replaced submit(custom:submitSuccess, custom:submitError) examples and it rules with submit()

* FORMS-13209: updated af-custom-functions version

* FORMS-13209: updated submission handler test

* FORMS-13209: updated tests

* FORMS-13209: updated tests

* FORMS-13209: updated tests

* FORMS-13209: added rule editor authoring cypress tests

* FORMS-13209: added submission handler rule tests

* FORMS-13209: updated af-custom-functions version

* FORMS-13209: updated tests

* FORMS-13209: updated tests

* FORMS-13209: added rule editor authoring cypress tests

* FORMS-13209: added submission handler rule tests

* FORMS-13209: updated af-custom-functions version

* FORMS-13209: updated tests

* FORMS-13209: updated tests

* FORMS-13209: updated tests

* FORMS-13209: updated tests

* FORMS-13209: added af-custom-functions in FormView and replaced hardcoded submission handlers with defaultSubmit handlers af-custom-functions

* FORMS-13209: minor update

---------

Co-authored-by: Arun Kumar Attri <[email protected]>
#1196)

* FORMS-12822 : format should not be visible when no pattern is selected

* FORMS-12822 : changes var to let as per ES6 in utils.js
…d submit() rule in examples (#1191)

* FORMS-13209: added check to override hardcoded submitSuccess and submitError hadnlers

* FORMS-13209: updated af2 runtime version

* FORMS-13209: added rule editor authoring cypress tests

* FORMS-13209: added submission handler rule tests

* FORMS-13209: replaced submit(custom:submitSuccess, custom:submitError) examples and it rules with submit()

* FORMS-13209: updated af-custom-functions version

* FORMS-13209: updated submission handler test

* FORMS-13209: updated tests

* FORMS-13209: updated tests

* FORMS-13209: updated tests

* FORMS-13209: added rule editor authoring cypress tests

* FORMS-13209: added submission handler rule tests

* FORMS-13209: updated af-custom-functions version

* FORMS-13209: updated tests

* FORMS-13209: updated tests

* FORMS-13209: added rule editor authoring cypress tests

* FORMS-13209: added submission handler rule tests

* FORMS-13209: updated af-custom-functions version

* FORMS-13209: updated tests

* FORMS-13209: updated tests

* FORMS-13209: updated tests

* FORMS-13209: updated tests

* FORMS-13209: added af-custom-functions in FormView and replaced hardcoded submission handlers with defaultSubmit handlers af-custom-functions

* FORMS-13209: minor update

---------

Co-authored-by: Arun Kumar Attri <[email protected]>
FORMS-13935 update examples for aemcomponents.dev

FORMS-13935 update examples for aemcomponents.dev
…lue without default/placeholder set (#1203)

* Added test case

* Adding actual fix

* Improved test case

* Small fix
@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 100 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@rismehta
Copy link
Collaborator

rismehta commented Jul 10, 2024

I have created FORMS-15321 to track the rule editor failures, these are due to incorrect CSS selectors or absence of FT, merging this PR

@rismehta rismehta merged commit e89037b into release/650 Jul 10, 2024
6 of 11 checks passed
@rismehta rismehta deleted the master-to-650-3_July_24 branch July 10, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.