Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new Productreference class and htl file #334

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Satish-Pothabathula
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 72.62%. Comparing base (34e2ddb) to head (f0f40a0).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...a/core/models/commerce/MyProductReferenceImpl.java 0.00% 12 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (34e2ddb) and HEAD (f0f40a0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (34e2ddb) HEAD (f0f40a0)
unittests 2 1
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #334      +/-   ##
============================================
- Coverage     77.84%   72.62%   -5.22%     
  Complexity       72       72              
============================================
  Files             4        5       +1     
  Lines           167      179      +12     
  Branches         31       31              
============================================
  Hits            130      130              
- Misses           20       32      +12     
  Partials         17       17              
Flag Coverage Δ
unittests 72.62% <0.00%> (-5.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LSantha
Copy link
Collaborator

LSantha commented Aug 30, 2024

@Satish-Pothabathula , it looks good to me! I've approved it but let's keep this as a draft PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants