Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow form block to submit to an arbitraty url #65

Merged
merged 4 commits into from
Aug 6, 2024
Merged

feat: allow form block to submit to an arbitraty url #65

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e55017
feat: allow form block to submit to an arbitraty url
shsteimer Jun 24, 2024
7718ad1
submit link is required
shsteimer Jun 24, 2024
ae5dc44
feat: re-enable form on back button
shsteimer Jun 25, 2024
d9c59f5
fix: remove sampleRum calls, ensure submit is re-enabled when submiss…
shsteimer Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions blocks/form/form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import createField from './form-fields.js';
import { sampleRUM } from '../../scripts/aem.js';

async function createForm(formHref) {
async function createForm(formHref, submitHref) {
const { pathname } = new URL(formHref);
const resp = await fetch(pathname);
const json = await resp.json();

const form = document.createElement('form');
// eslint-disable-next-line prefer-destructuring
form.dataset.action = pathname.split('.json')[0];
form.dataset.action = submitHref;

const fields = await Promise.all(json.data.map((fd) => createField(fd, form)));
fields.forEach((field) => {
Expand Down Expand Up @@ -45,13 +43,6 @@ function generatePayload(form) {
return payload;
}

function handleSubmitError(form, error) {
// eslint-disable-next-line no-console
console.error(error);
form.querySelector('button[type="submit"]').disabled = false;
sampleRUM('form:error', { source: '.form', target: error.stack || error.message || 'unknown error' });
}

async function handleSubmit(form) {
if (form.getAttribute('data-submitting') === 'true') return;

Expand All @@ -70,7 +61,6 @@ async function handleSubmit(form) {
},
});
if (response.ok) {
sampleRUM('form:submit', { source: '.form', target: form.dataset.action });
if (form.dataset.confirmation) {
window.location.href = form.dataset.confirmation;
}
Expand All @@ -79,17 +69,21 @@ async function handleSubmit(form) {
throw new Error(error);
}
} catch (e) {
handleSubmitError(form, e);
// eslint-disable-next-line no-console
console.error(e);
} finally {
form.setAttribute('data-submitting', 'false');
submit.disabled = false;
}
}

export default async function decorate(block) {
const formLink = block.querySelector('a[href$=".json"]');
if (!formLink) return;
const links = [...block.querySelectorAll('a')].map((a) => a.href);
const formLink = links.find((link) => link.startsWith(window.location.origin) && link.endsWith('.json'));
const submitLink = links.find((link) => link !== formLink);
if (!formLink || !submitLink) return;

const form = await createForm(formLink.href);
const form = await createForm(formLink, submitLink);
block.replaceChildren(form);

form.addEventListener('submit', (e) => {
Expand Down