Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoplay placeholder #63

Merged
merged 6 commits into from
Jun 13, 2024
Merged

Autoplay placeholder #63

merged 6 commits into from
Jun 13, 2024

Conversation

shsteimer
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

https://autoplay-placeholder--aem-block-collection--adobe.hlx.page/drafts/shsteimer/video (auotplay w/ placeholder as LCP)
https://autoplay-placeholder--aem-block-collection--adobe.hlx.page/block-collection/video

@shsteimer shsteimer requested a review from fkakatie May 7, 2024 17:55
Copy link

aem-code-sync bot commented May 7, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented May 7, 2024

Page Scores Audits Google
/block-collection/video PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/shsteimer/video PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to autoplay-placeholder May 7, 2024 17:56 Inactive
@shsteimer shsteimer marked this pull request as ready for review May 7, 2024 17:57
@shsteimer
Copy link
Collaborator Author

shsteimer commented May 7, 2024

@fkakatie @davidnuescheler

I'm a bit unsure on the A11y aspects of this.

  • When we hide the placeholder image, regardless of the autoplay setting, should we set it as aria-hidden? I don't think we can use hidden or display: none when it's the LCP.
  • for autoplaying video, should clicking the video pause it? or is the prefers reduced motion check I have in there enough?

@aem-code-sync aem-code-sync bot temporarily deployed to autoplay-placeholder May 7, 2024 18:38 Inactive
@shsteimer shsteimer merged commit b8e26a5 into main Jun 13, 2024
4 checks passed
@shsteimer shsteimer deleted the autoplay-placeholder branch June 13, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants