Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookieconsent next #58

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Cookieconsent next #58

merged 5 commits into from
Mar 22, 2024

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Mar 21, 2024

@kptdobe kptdobe requested a review from chicharr March 21, 2024 08:47
Copy link

aem-code-sync bot commented Mar 21, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Mar 21, 2024

Page Scores Audits Google
/block-collection/cookie-consent-details-demo PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@chicharr chicharr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a comment regarding the changes in the README

* if the 'cookie-consent' metadata is set on the page.
* @param {Element} el the DOM element in which the consent preference link is to be set up
*/
export function setupConsentPreferenceLink(el = document) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a very good idea

@kptdobe kptdobe merged commit de7f903 into cookieconsent Mar 22, 2024
4 checks passed
@kptdobe kptdobe deleted the cookieconsent-next branch March 22, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants