Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select value #57

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Select value #57

merged 7 commits into from
Feb 12, 2025

Conversation

shsteimer
Copy link
Collaborator

@shsteimer shsteimer commented Feb 27, 2024

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #40
based on work by @felix-staud in #55 but moved to a local branch and fixed one small issue with casing.

Test URLs:

flx-sta and others added 7 commits January 26, 2024 11:48
the `<select>` element does not support the `value` attribute thus the `option.value` needs to be compared to the `fd.Value` instead of ~~`select.value`~~
update mountpoint
update mount-point
Copy link

aem-code-sync bot commented Feb 27, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Feb 27, 2024

Page Scores Audits Google
/block-collection/form PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@shsteimer shsteimer merged commit 9fed5ca into main Feb 12, 2025
3 checks passed
@shsteimer shsteimer deleted the select-value branch February 12, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial value for selects not working (form block)
3 participants