-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fragment) - inherit section dataset #19
base: main
Are you sure you want to change the base?
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
Alternatively, you can provide a URL on your fork. |
@rofe I can't seem to make the fork work on the I can show this in action in the project I'm currently working on: The sidebar from that page is a (auto-blocked) fragment. Before:
After:
![]() Is this helpful? |
|
|
Building on @rofe's #4 where the fragment section's classes were propagated to the target section, this PR also propagates the dataset.
In the boilerplate, section metadata:
Test URLs:
Before: https://main--helix-block-collection--adobe.hlx.page/block-collection/fragment
After: (cannot add after url, as I don't have permissions to push a branch in this repo)