Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second pass footer #235

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Second pass footer #235

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a004d7
Bugs: Removed Spectrum & Made mobile responsive
BaskarMitrah Sep 27, 2024
aaaa9f3
Made laptop responsive
BaskarMitrah Sep 27, 2024
f21db66
Fixed divider issues on desktop
BaskarMitrah Sep 27, 2024
7f5ee06
Fixed border issues
BaskarMitrah Sep 27, 2024
499e68a
Fix : Design issues
BaskarMitrah Sep 27, 2024
79ceec7
Removed unwanted code
BaskarMitrah Sep 27, 2024
30f4533
Fix : Design issues
BaskarMitrah Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 83 additions & 19 deletions hlx_statics/blocks/footer/footer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ footer {
}
}

footer > div {
footer>div {
box-sizing: border-box;
max-width: 1280px;
margin: 0 auto;
}

footer > div ul {
footer>div ul {
list-style: none;
padding: 0;
}
Expand All @@ -34,16 +34,16 @@ footer h3.spectrum-Heading--XS {
white-space: nowrap;
}

footer > div ul.spectrum-Body--sizeS {
footer>div ul.spectrum-Body--sizeS {
padding-top: 40px;
padding-right: 16px;
}

footer > div ul.spectrum-Body--sizeS > li {
footer>div ul.spectrum-Body--sizeS>li {
margin-top: 16px;
}

footer > div ul.spectrum-Body--sizeS > li:first-of-type {
footer>div ul.spectrum-Body--sizeS>li:first-of-type {
margin-top: 0;
}

Expand Down Expand Up @@ -80,19 +80,12 @@ footer .footer-divider {
height: 100%;
}

footer div.footer-links-container-inner > div:nth-child(1) {
footer div.footer-links-container-inner>div:nth-child(1) {
position: relative;
grid-area: apis;
}

footer
div.footer-links-container-inner
> div:nth-child(1)
> div
> ul
> li
> strong
> a {
footer div.footer-links-container-inner>div:nth-child(1)>div>ul>li>strong>a {
padding-bottom: 60px !important;
}

Expand All @@ -105,7 +98,7 @@ footer .footer-apis-container {
flex-direction: column;
}

footer .footer-apis-container > div {
footer .footer-apis-container>div {
margin: 0;
}
}
Expand All @@ -118,12 +111,12 @@ footer .footer-services-container ul {
padding-top: 60px !important;
}

footer div.footer-links-container-inner > div:nth-child(2) {
footer div.footer-links-container-inner>div:nth-child(2) {
position: relative;
grid-area: blogs;
}

footer div.footer-links-container-inner > div:nth-child(3) {
footer div.footer-links-container-inner>div:nth-child(3) {
position: relative;
grid-area: support;
}
Expand All @@ -140,10 +133,14 @@ footer .footer-legal ul {
color: rgb(70, 70, 70);
}

footer .footer-legal ul > li {
footer .footer-legal ul>li {
margin-right: 32px;
}

footer .footer-divider {
display: block;
}

@media screen and (max-width: 768px) {
footer .footer-legal {
flex-direction: column;
Expand All @@ -162,8 +159,75 @@ footer .footer-legal p {
display: block;
margin-top: 16px;
}

footer .footer-divider {
display: none;
}

footer .footer-links-container {
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
}

footer .footer-legal ul {
flex-direction: column;
}

footer .footer-horizontal {
width: 85% !important;
}

footer {
padding-left: 40px;
width: 85%;
}

footer h3 {
font-size: 19px !important;
}

footer a {
font-size: 17px !important;
}

footer .footer-links-container-inner {
justify-content: unset;
}

footer .footer-legal {
flex-direction: column !important;
align-items: baseline !important;
width: 100%;
}

}

@media screen and (min-width : 768px) and (max-width : 1024px) {

footer {
padding-left: 40px;
width: 85%;
}

footer .footer-divider {
display: none;
}

footer .footer-links-container-inner {
justify-content: unset;
}

footer .footer-legal {
flex-direction: column !important;
align-items: baseline !important;
width: 100%;
}

}

footer .footer-horizontal {
margin-top: 56px;
}
width: 100% !important;
}
3 changes: 1 addition & 2 deletions hlx_statics/blocks/footer/footer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { readBlockConfig } from '../../scripts/lib-helix.js';
import {
createTag,
setExpectedOrigin,
createTag
} from '../../scripts/lib-adobeio.js';

function buildFooter(html) {
Expand Down
20 changes: 20 additions & 0 deletions hlx_statics/styles/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,3 +854,23 @@ main .heading6 h6 {
.warning-icon{
color: rgb(110, 110, 110);
}

.spectrum-Divider--sizeM {
--spectrum-divider-height: 2px;
--spectrum-divider-vertical-height: 2px;
--spectrum-divider-vertical-width: 2px;
}

.spectrum-Divider {
--spectrum-divider-vertical-height: 100%;
border: none;
border-radius: var(--spectrum-divider-height);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we flatten these too? (i.e. replace with values to remove dependency on spectrum.min)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay @melissag-ensemble

border-width: var(--spectrum-divider-height);
height: var(--spectrum-divider-height);
overflow: visible;
width: 2px !important;
}

.spectrum-Divider--sizeM{
background-color: rgb(213,213,213);
}