Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hero browser error #229

Open
wants to merge 2 commits into
base: fresh-spectrum-less
Choose a base branch
from

Conversation

melissag-ensemble
Copy link
Collaborator

@melissag-ensemble melissag-ensemble commented Sep 25, 2024

Description

Check for null to prevent browser error logged to console:
Screenshot 2024-09-25 at 10 11 02 AM

Related Issue

Motivation and Context

How Has This Been Tested?

Console error: failed to load module for hero TypeError: Cannot read properties of null (reading 'toLocaleLowerCase')

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

aem-code-sync bot commented Sep 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@melissag-ensemble melissag-ensemble changed the base branch from main to fresh-spectrum-less September 25, 2024 17:06
Copy link

aem-code-sync bot commented Sep 25, 2024

@melissag-ensemble melissag-ensemble changed the title fix: fix: hero browser error Sep 25, 2024
@melissag-ensemble melissag-ensemble marked this pull request as ready for review September 25, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants