Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression from https://github.com/adobe/adobe-dx/pull/201 #202

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Fix regression from https://github.com/adobe/adobe-dx/pull/201 #202

merged 1 commit into from
Sep 4, 2023

Conversation

lukdz
Copy link
Contributor

@lukdz lukdz commented Sep 1, 2023 •
edited
Loading

delete single quotes
that were consumed by previously removed eval

For details please see previous discussion:
#201 (comment)

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lukaszdzwoniarek
delete single quotes
6d7fe1c 
that were consumed by previously removed eval
@lukdz lukdz changed the title delete single quotes Fix regression from https://github.com/adobe/adobe-dx/pull/201 Sep 1, 2023
@lukdz lukdz mentioned this pull request Sep 1, 2023
Merged
10 tasks
praveenrv
praveenrv approved these changes Sep 2, 2023
View reviewed changes
Copy link

@praveenrv praveenrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working fine with binding parameters.

npeltier
npeltier approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@npeltier npeltier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukdz !

@npeltier npeltier merged commit bdfbb48 into adobe:master Sep 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenrv praveenrv praveenrv approved these changes

@npeltier npeltier npeltier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukdz @npeltier @praveenrv @lukaszdzwoniarek