Add missing xml prolog and namespaces #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unneeded @JsonRootName annotations Use central "Include.NON_EMPTY" config instead of annotating every POJO
With 2.17.0+, they added polymorphic (de-)serialization using "xsi:type" so we can finally use Jackson only for all requests and responses. :)
|
More refactorings: jackson-databind-xml now supports polymorphic (de-)serialization with I could finally get rid of JAX-B for (de-)serialization of The only caveat is that |
Spring now validates the contents of the "content-type" header. The value must contain a "/".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<?xml version="1.0" encoding="UTF-8"?>)While the AWS SDKs do not depend on this, it is the right thing to do.
Other libraries like the aiohttp-s3-client depend on the declarations being present in the XML responses.
Related Issue
#1754
Tasks