feat: product:lastModifiedAt from Catalog Service #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandepass
reviewed
Dec 16, 2024
| @@ -25,6 +25,7 @@ | |||
| <meta property="product:availability" content="In stock"> | |||
| <meta property="product:price.amount" content="29"> | |||
| <meta property="product:price.currency" content="USD"> | |||
| <meta property="product:lastModifiedAt" content="2024-12-16T06:25:43.024Z"> | |||
There was a problem hiding this comment.
Since product:lastModifiedAt is not part of Open Graph product specification I'm not sure we should use that. Maybe last-modified would be more appropriate?
From the index you can also pull out the last-modified header which is returned by Edge Delivery Services. But this would correspond to when the document was published.
I'm guessing it would be better track the date from the catalog service and not the date the document was published. wdyt @dicagno?
…obe-rnd/helix-commerce-api into feat/product_last-modified-at
maxakuru
approved these changes
Dec 16, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
# [1.12.0](v1.11.5...v1.12.0) (2024-12-16) ### Features * product:lastModifiedAt from Catalog Service ([#68](#68)) ([51663ff](51663ff))
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR proposed for #67
According to the proposed implementation, this
product:lastModifiedAtis rendered as a meta tag by default, and can haveundefinedvalue in case the data source does not expose it.