Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option values #62

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Add option values #62

merged 3 commits into from
Dec 11, 2024

Conversation

herzog31
Copy link
Member

  • Add missing option values and type
  • Add data-name to LD+JSON script tag to better distinguish from multiple tags.

@herzog31 herzog31 added the bug Something isn't working label Dec 11, 2024
@herzog31 herzog31 requested a review from maxakuru December 11, 2024 09:04
maxakuru
maxakuru approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@maxakuru maxakuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the data attr will not make it to the published markup, but we could still merge the change here for now

adobe/helix-html2md#571

@herzog31 herzog31 merged commit 08566d0 into main Dec 11, 2024
4 checks passed
@herzog31 herzog31 deleted the additional-data branch December 11, 2024 12:46
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxakuru maxakuru maxakuru approved these changes

Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herzog31 @maxakuru