Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UE: Removing fieldType from all component definitions #176

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TalmizAhmed
Copy link

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

Copy link

aem-code-sync bot commented Sep 24, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 24, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@TalmizAhmed
Copy link
Author

FieldType is now supported via the sling models after the merge of this PR: adobe/aem-core-forms-components#1409

@nit23uec
Copy link
Collaborator

since this is a breaking change, we have to wait till cc is release, updated in archetype and CMGR picks up the new archetype.

@TalmizAhmed
Copy link
Author

Core components version update that contained that change went into archetype on Oct 8.
@nit23uec Are we good to go with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants