Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ContainerElement as abstract class #500

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

BirgitBoss
Copy link
Collaborator

fixes #333

ContainerElement introduced as abstract class

  • key enums adapted
  • changelog updates: see there for detailed changes

Copy link
Collaborator

@s-heppner s-heppner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot judge the ASCIIDoc formatting, as I have no experience with it myself, but other than that minor missing empty line, it is as we discussed it.

@@ -34,6 +32,8 @@ FragmentKeys --|> AasReferableNonIdentifiables
AasReferables --|> AasReferableNonIdentifiables
AasReferables --|> AasIdentifiables
AasReferableNonIdentifiables --|> AasSubmodelElements
AasSubmodelElements --|> AasContainerSubmodelElements
AasSubmodelElements --|> AasNonContainerSubmodelElements
GloballyIdentifiables --|> AasIdentifiables
GloballyIdentifiables --|> GenericGloballyIdentifiables
@enduml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a new line missing at the end of the file.

@BirgitBoss BirgitBoss merged commit 36697b0 into IDTA-01001-3-1_working Dec 13, 2024
2 checks passed
s-heppner added a commit to aas-core-works/aas-core-meta that referenced this pull request Jan 7, 2025
The new version of the specification introduces a
new abstract class `Container_element`. This class
is used to describe concrete classes that are able
to "contain" other classes from the meta-model.

Concretely, this means that the classes:
- `Annotated_relationship_element`
- `Entity`
- `Submodel_element_collection`
- `Submodel_element_list`
now inherit from the `Container_element` class.

See these resources:
- [Link to spec]
- Issue that introduces the class: [aas-specs#420]
- Issue for the reasoning behind the
  new class: [aas-specs#333]
- PR that introduces it into
  the spec: [aas-specs#500]

[Link to spec]: https://admin-shell-io.github.io/aas-specs-antora/IDTA-01001/v3.1/spec-metamodel/submodel-elements.html#container-element-and-overview-of-data-element-types
[aas-specs#420]: admin-shell-io/aas-specs#420
[aas-specs#333]: admin-shell-io/aas-specs#333
[aas-specs#500]: admin-shell-io/aas-specs#500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants