Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Catalina (10.14+) #2

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Fixes for Catalina (10.14+) #2

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
10e24c8
ADD .gitignore
Dec 19, 2019
92cef02
FIX target to 64bit
Dec 19, 2019
8072608
FIX 'Gestalt' is deprecated for appcast url
Dec 19, 2019
a59ed4b
FIX propertyListFromData deprecated
Dec 19, 2019
eb858f0
FIX 'NSLeftMouseDraggedMask', 'NSLeftMouseUp', 'NSLeftMouseUpMask' de…
Dec 19, 2019
7fcb03a
FIX 'NSUnarchiver', 'NSArchiver', 'NSCompositeSourceOver' deprecated
Dec 19, 2019
192e620
FIX 'NSLeftMouseDraggedMask', 'NSLeftMouseUp', 'NSLeftMouseUpMask' de…
Dec 19, 2019
cee6b98
FIX 'NSOnState', 'NSOffState', 'NSDeviceIndependentModifierFlagsMask'…
Dec 19, 2019
a773654
FIX 'NSLeftMouseDraggedMask', 'NSLeftMouseUp', 'NSLeftMouseUpMask' de…
Dec 19, 2019
5f8ec0c
FIX 'NSAlternateKeyMask', 'NSCommandKeyMask' is deprecated
Dec 19, 2019
158d201
FIX 'NSLeftMouseDraggedMask', 'NSLeftMouseUp', 'NSShiftKeyMask' depre…
Dec 19, 2019
cc534c4
FIX 'NSUnarchiver', 'unarchiveObjectWithData', 'NSArchiver', 'archive…
Dec 19, 2019
87a73f5
FIX NSOnState deprecated
Dec 19, 2019
afdd4bb
FIX ERROR Format String Issue
Dec 19, 2019
662d417
FIX dataFromPropertyList propertyListFromData deprecated - NOT FIXED …
Dec 19, 2019
60e76e4
FIX deprecated
Dec 19, 2019
0af37cc
FIX 'filename' is deprecated: first deprecated in macOS 10.6 - Use -U…
Dec 19, 2019
17cb949
FIX beginSheetForDirectory is deprecated
Dec 19, 2019
4e74561
TODO fix scrolling
Dec 20, 2019
b27dc39
FIX 'drawWithBox:' is deprecated
Dec 20, 2019
9e296a9
FIX building issues
Dec 22, 2019
a16d97a
FIX l18n
Dec 22, 2019
19a2c38
FIX alert for loading Frameworks libs
Dec 22, 2019
81b4c0e
Cleanup removing comments and old code
Dec 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions FPDocumentView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,15 @@ - (void)scrollToMidpointOnPage:(unsigned int)page point:(NSPoint)midPoint
NSPoint viewPoint = [self convertPoint:midPoint fromPage:page];
NSPoint viewOrigin = NSMakePoint(floorf(viewPoint.x - viewWidth/2.0),
floorf(viewPoint.y - viewHeight/2.0));
/*
TODO
Fix the error:
Sending 'NSPoint' (aka 'struct CGPoint') to parameter of incompatible type 'NSRect' (aka 'struct CGRect')
[[_scrollView contentView] scrollToPoint:
[[_scrollView contentView] constrainBoundsRect:viewOrigin]];
*/
[[_scrollView contentView] scrollToPoint:viewOrigin];

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is left to do for this TODO? Would it be possible for you to do the fix?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't know what I did here ;-)
Once I removed the constrainBoundsRect I get rid of the error but what are the implication? No idea.

[_scrollView reflectScrolledClipView:[_scrollView contentView]];
}

Expand Down