Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartling translations are completed for commit 53a67469502ec7ef60fb662eb057620a801e50de from main #1227

Merged

Conversation

smartling-github-connector[bot]
Copy link
Contributor

Please review this translation pull request. The relevant Smartling translation job is available here - https://dashboard.smartling.com/app/accounts/aaa8fc6f/account-jobs/7fd223df3:88ilifpgxlc6
Here is a link to the source commit which triggered translation - 53a6746

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 11:18am

@bzavhorodskyi
Copy link
Collaborator

@tomokogoto1
Copy link
Collaborator

Hi @bzavhorodskyi I can still see 2 subtitles showing in EN.
https://dev-docs-lxgay6qz4-product-content.vercel.app/ko/sdk/react-native/v4/features/subscriptions

Record the purchase region (iOS only)
2. Record subscription information {#record-subscription-information}

Can you apply translation for above copy?

@bzavhorodskyi
Copy link
Collaborator

bzavhorodskyi commented Jan 13, 2025

Hi @bzavhorodskyi I can still see 2 subtitles showing in EN. https://dev-docs-lxgay6qz4-product-content.vercel.app/ko/sdk/react-native/v4/features/subscriptions

Record the purchase region (iOS only) 2. Record subscription information {#record-subscription-information}

Can you apply translation for above copy?

@tomokogoto1 In the scope of this translation job were translated only a few paragraphs: https://dashboard.smartling.com/app/projects/7fd223df3/account-jobs/7fd223df3:88ilifpgxlc6/files

@tomokogoto1
Copy link
Collaborator

@bzavhorodskyi The Smartling job was automatically completed. Please let me know if the content was not delivered.

@bzavhorodskyi
Copy link
Collaborator

@tomokogoto1 I don`t know, for this job we had only 54 words:
image
image

@bzavhorodskyi
Copy link
Collaborator

@tomokogoto1
Copy link
Collaborator

I confirm KO and ZH are fully localized, but the JA contains EN subheadings still in the preview.

#1227 (comment)

@bzavhorodskyi
Copy link
Collaborator

I confirm KO and ZH are fully localized, but the JA contains EN subheadings still in the preview.

#1227 (comment)

@tomokogoto1 This PR was created from the Only KO Smartling project, so I think we need to check only Ko translations here

@tomokogoto1
Copy link
Collaborator

Ah, OK. In that case, the KO version is fixed and good to go @bzavhorodskyi

@bzavhorodskyi bzavhorodskyi merged commit a9b3e9a into main Jan 20, 2025
6 checks passed
@bzavhorodskyi bzavhorodskyi deleted the smartling-translation-completed-88ilifpgxlc6-from-main branch January 20, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants