Multiple headers with the same key return a comma-separated string #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangfeld
reviewed
Feb 12, 2019
|
|
||
| client_messages.should be == [ | ||
| [Stream::Connected.new, @stream], | ||
| [Event.new('Status', 'Channel' => 'SIP/101-3f3f', 'Variable' => 'CDR(ds_type)=Test-INT,from_user=ssether,companyID=Test', 'ActionID' => '2'), @stream], |
There was a problem hiding this comment.
What about this?
Suggested change
| [Event.new('Status', 'Channel' => 'SIP/101-3f3f', 'Variable' => 'CDR(ds_type)=Test-INT,from_user=ssether,companyID=Test', 'ActionID' => '2'), @stream], | |
| [Event.new('Status', 'Channel' => 'SIP/101-3f3f', 'Variable' => ['CDR(ds_type)=Test-INT', 'from_user=ssether', 'companyID=Test'], 'ActionID' => '2'), @stream], |
There was a problem hiding this comment.
I'd rather a 'string' to not change the interface, but it could return a 'map' with key / values
There was a problem hiding this comment.
The problem with a Hash is that it is specific to the Variable header, and not a generic way of expressing multiple values for any header.
|
@lpradovera Would you mind shepherding this through? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issue #42 support multiple headers