[FEATURE] I18n now uses a formatter if specified by overriding output… #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,5 @@ | |||
| class AdhearsionI18n::Formatter < Adhearsion::CallController::Output::Formatter | |||
There was a problem hiding this comment.
This is worth submitting as a PR to Adhearsion
|
@benlangfeld can I get a review from you here? |
|
I'd second that this needs to go in Ahn 3. @polysics Please prep a PR. Other than that, no major complaints. |
| if prompt.empty? | ||
| output_formatter.ssml_for_text(text, language: this_locale) | ||
| else | ||
| RubySpeech::SSML.draw language: this_locale do | ||
| if Adhearsion.config.i18n.fallback | ||
| audio(src: prompt) { string text } |
There was a problem hiding this comment.
So we can't pass this fallback text through the formatter too?
|
Did this make it into Adhearsion 3 yet? |
|
I don't remember anything further than what's here. |
bklang
force-pushed
the
feature/use_formatter
branch
from
97e06d8
to
5b4d009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_formatter