Don’t override server-supplied timeouts #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of PromptBuilder makes a somewhat naive assumption that the provided
timeout
setting should apply to three different kinds of time-outs. The intent seems to apply best to theinitial-timeout
, or the amount of time the input should wait for the user to start signaling a response. But it’s also default-applied tomax-silence
andinter-digit
timeouts. This is bad for callers who may take up to 4 seconds to start talking, and then have to wait up to 4 additional seconds after they stop talking for an answer. The server-supplied timeouts (LumenVox is around 800ms) should be the default, while still being possible to override them by the caller to#ask
.